Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: should not cache tracing instance #9086

Merged
merged 2 commits into from
Jan 23, 2025
Merged

fix: should not cache tracing instance #9086

merged 2 commits into from
Jan 23, 2025

Conversation

h-a-n-a
Copy link
Contributor

@h-a-n-a h-a-n-a commented Jan 22, 2025 •
edited
Loading

Summary

Only cache @rspack/tracing instead of tracing instance to avoid tracing being written to the incorrect context.

After:

image

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Jan 22, 2025
@netlify Netlify
Copy link

netlify bot commented Jan 22, 2025 •
edited
Loading

✅ Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit 9b7d042
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/6790c59259a4730008a99485

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Jan 22, 2025

CodSpeed Performance Report

Merging #9086 will not alter performance

Comparing fix-tracing (9b7d042) with main (2d25168)

Summary

✅ 3 untouched benchmarks

@h-a-n-a h-a-n-a enabled auto-merge (squash) January 22, 2025 11:29
@h-a-n-a h-a-n-a merged commit 64bc74a into main Jan 23, 2025
30 checks passed
@h-a-n-a h-a-n-a deleted the fix-tracing branch January 23, 2025 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hardfist hardfist hardfist approved these changes

@chenjiahan chenjiahan Awaiting requested review from chenjiahan

Assignees
No one assigned
Labels
team The issue/pr is created by the member of Rspack.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@h-a-n-a @hardfist