Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: should not have warnings for cjs when using dll #9091

Merged
merged 2 commits into from
Jan 23, 2025
Merged

fix: should not have warnings for cjs when using dll #9091

merged 2 commits into from
Jan 23, 2025

Conversation

ahabhgk
Copy link
Contributor

@ahabhgk ahabhgk commented Jan 22, 2025

Summary

fix #9016

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Jan 22, 2025
@ahabhgk ahabhgk enabled auto-merge (squash) January 22, 2025 13:44
Copy link

netlify bot commented Jan 22, 2025

Deploy Preview for rspack ready!

Name Link
🔨 Latest commit 6fcc0c2
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/6791c97e55a911000800618f
😎 Deploy Preview https://deploy-preview-9091--rspack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codspeed-hq bot commented Jan 22, 2025

CodSpeed Performance Report

Merging #9091 will not alter performance

Comparing fix-dll (6fcc0c2) with main (1336548)

Summary

✅ 3 untouched benchmarks

@ahabhgk ahabhgk merged commit 404bfb3 into main Jan 23, 2025
30 checks passed
@ahabhgk ahabhgk deleted the fix-dll branch January 23, 2025 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: DLL Reference plugin results in ESModulesLinkingWarning for CJS files
2 participants