Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: require local module and support new require #9114

Merged
merged 2 commits into from
Jan 26, 2025
Merged

fix: require local module and support new require #9114

merged 2 commits into from
Jan 26, 2025

Conversation

ahabhgk
Copy link
Contributor

@ahabhgk ahabhgk commented Jan 24, 2025 •
edited
Loading

Summary

fix require("AMDLocalModule") and support new require("./cjs")

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@ahabhgk ahabhgk enabled auto-merge (squash) January 24, 2025 09:50
@github-actions github-actions bot added release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack. labels Jan 24, 2025
@netlify Netlify
Copy link

netlify bot commented Jan 24, 2025 •
edited
Loading

✅ Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit 791d2d8
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/67936d5a45f66900093eba24

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Jan 24, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #9114 will not alter performance

Comparing fix-amd-req (791d2d8) with main (f6401df)

Summary

✅ 4 untouched benchmarks

@ahabhgk ahabhgk changed the title fix: amd require single value for local module feat: require local module and support new require Jan 24, 2025
@github-actions github-actions bot added release: feature release: feature related release(mr only) and removed release: bug fix release: bug related release(mr only) labels Jan 24, 2025
@ahabhgk ahabhgk requested review from h-a-n-a and SyMind January 24, 2025 11:26
@ahabhgk ahabhgk changed the title feat: require local module and support new require fix: require local module and support new require Jan 24, 2025
@github-actions github-actions bot added release: bug fix release: bug related release(mr only) and removed release: feature release: feature related release(mr only) labels Jan 24, 2025
@ahabhgk ahabhgk merged commit c16b99c into main Jan 26, 2025
36 checks passed
@ahabhgk ahabhgk deleted the fix-amd-req branch January 26, 2025 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SyMind SyMind SyMind approved these changes

@h-a-n-a h-a-n-a Awaiting requested review from h-a-n-a

Assignees
No one assigned
Labels
release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ahabhgk @SyMind