Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: highlight error after building #280

Closed
wants to merge 1 commit into from

Conversation

FireBushtree
Copy link
Contributor

Summary

I tried to use PrismAsyncLight instead of PrismLight, it works. But react-syntax-highlight said while code splits are loaded the code will show with line numbers but without highlighting., i worry if it will cause other bugs.

Related Issue

https://github.com//issues/272

Checklist

  • I have added changeset via pnpm run change.
  • I have updated the documentation.
  • I have added tests to cover my changes.

@netlify
Copy link

netlify bot commented Oct 27, 2023

Deploy Preview for aquamarine-blini-95325f ready!

Name Link
🔨 Latest commit c48a55e
🔍 Latest deploy log https://app.netlify.com/sites/aquamarine-blini-95325f/deploys/653b84e9805e2b000886766c
😎 Deploy Preview https://deploy-preview-280--aquamarine-blini-95325f.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 62 (🔴 down 3 from production)
Accessibility: 79 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@sanyuan0704
Copy link
Contributor

@chenjiahan
Copy link
Member

Yes, it looks like there are some issues with the initial styling.

@sanyuan0704
Copy link
Contributor

Yes, it looks like there are some issues with the initial styling.

Any update? @FireBushtree

@FireBushtree
Copy link
Contributor Author

Yes, it looks like there are some issues with the initial styling.

Any update? @FireBushtree

sorry, i will try to fix this week. Is it will overtime?

@sanyuan0704
Copy link
Contributor

Not yet, and expect your solution this week 😄

@FireBushtree
Copy link
Contributor Author

Actually, this is not a bug, just use highlight-feature is fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants