Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: custom theme not working #313

Merged
merged 2 commits into from
Nov 2, 2023
Merged

fix: custom theme not working #313

merged 2 commits into from
Nov 2, 2023

Conversation

kainstar
Copy link
Contributor

@kainstar kainstar commented Nov 2, 2023 •
edited
Loading

Summary

Change runtime code require theme alias path @theme instead of @rspress/theme-default.

Related Issue

#310

Checklist

  • I have added changeset via pnpm run change.
  • I have updated the documentation.
  • I have added tests to cover my changes.

@netlify Netlify
Copy link

netlify bot commented Nov 2, 2023 •
edited
Loading

✅ Deploy Preview for aquamarine-blini-95325f ready!

Name Link
🔨 Latest commit 12fa665
🔍 Latest deploy log https://app.netlify.com/sites/aquamarine-blini-95325f/deploys/6543823d649e540008450759
😎 Deploy Preview https://deploy-preview-313--aquamarine-blini-95325f.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 63 (🟢 up 1 from production)
Accessibility: 79 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@kainstar kainstar mentioned this pull request Nov 2, 2023
Closed
@sanyuan0704
Copy link
Contributor

Nice! That is what i want to do.

@sanyuan0704
Copy link
Contributor

Please add a changset and this maybe a patch change.
image

@sanyuan0704
Copy link
Contributor

@kainstar

@kainstar
Copy link
Contributor Author

kainstar commented Nov 2, 2023

changset has been added.

@sanyuan0704 sanyuan0704 merged commit 9659d65 into web-infra-dev:main Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kainstar @sanyuan0704