Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plugin-rss): fix dependency issues #908

Merged
merged 3 commits into from
Apr 5, 2024
Merged

fix(plugin-rss): fix dependency issues #908

merged 3 commits into from
Apr 5, 2024

Conversation

chenjiahan
Copy link
Member

Summary

  • Add the missing @rspress/shared dependency.
  • Import runtime methods from rspress/runtime instead of @rspress/runtime.
  • Remove @types/react from peerDependencies.

Checklist

  • I have added changeset via pnpm run change.
  • I have updated the documentation.
  • I have added tests to cover my changes.

Copy link

netlify bot commented Apr 5, 2024

Deploy Preview for aquamarine-blini-95325f ready!

Name Link
🔨 Latest commit 819586b
🔍 Latest deploy log https://app.netlify.com/sites/aquamarine-blini-95325f/deploys/660fcac74f7d5b0007271900
😎 Deploy Preview https://deploy-preview-908--aquamarine-blini-95325f.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 91 (🟢 up 5 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@chenjiahan chenjiahan merged commit 4053ec3 into main Apr 5, 2024
8 checks passed
@chenjiahan chenjiahan deleted the rss_deps_0405 branch April 5, 2024 11:51
@chenjiahan chenjiahan mentioned this pull request Apr 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant