Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the <input> element #1441

Closed
wants to merge 11 commits into from
Closed

Conversation

petele
Copy link
Collaborator

@petele petele commented Jul 16, 2024

Used compute_from: html.elements.input since there are a number of attributes that are recent, or very recent.

@github-actions github-actions bot added the feature definition Creating or defining new features or groups of features. label Jul 16, 2024
@petele petele requested a review from ddbeck August 8, 2024 15:52
@captainbrosset
Copy link
Contributor

Using compute_from the way you did seems like the right thing to do. A majority of the BCD keys are baseline high anyway, so might as well stick to the earliest of them that makes the feature be supported since the first versions of browsers.
Now, with that said, let's review the keys that are not baseline high:

  • api.HTMLInputElement.cancel_event: seems like a detail that's OK to ignore
  • html.elements.input.type_color: I could almost see this as a separate feature. As a developer, I would use a text input and a color input as two very different things.
  • api.HTMLInputElement.stepDown and api.HTMLInputElement.stepUp: seem ok to ignore to me.
  • html.elements.input.type_week: seems very specific, and I could see this being part of a date/time input feature, instead of here.
  • html.elements.input.type_password.insecure_login_handling: seems ok to ignore for now.

@captainbrosset
Copy link
Contributor

So, perhaps the right thing to do here is to rename this to something like Text input, and then create other features for Color inputs and Date and time inputs. What do you think?

@petele
Copy link
Collaborator Author

petele commented Aug 21, 2024

So, perhaps the right thing to do here is to rename this to something like Text input, and then create other features for Color inputs and Date and time inputs. What do you think?

I took it a step further and created features for the special input types where its a completely different input type or something other than text, using caniuse as a guideline.

Copy link
Collaborator

@autonome autonome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The feature name part I think should be fixed - if not made consistent, at least to specify that it's the type attribute in the multiple-types cases.

features/input-date-time.yml Show resolved Hide resolved
features/input-date-time.yml Show resolved Hide resolved
@autonome autonome mentioned this pull request Oct 23, 2024
@ddbeck ddbeck closed this in #2044 Nov 14, 2024
@ddbeck
Copy link
Collaborator

ddbeck commented Nov 14, 2024

Pete, we landed your work as part of #2044 (after some revisions). Thank you for doing the foundational work here!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature definition Creating or defining new features or groups of features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants