Add feature for moveBefore() DOM methods (and group some DOM features)
#2660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
feature definition
captainbrosset
approved these changes
Feb 17, 2025
foolip
reviewed
Feb 17, 2025
| @@ -1,6 +1,7 @@ | |||
| name: getHTML() | |||
| description: The `getHTML()` method of `Element` and `ShadowRoot` objects serializes an element's DOM to an HTML string. | |||
| spec: https://html.spec.whatwg.org/multipage/dynamic-markup-insertion.html#html-serialization-methods | |||
| group: dom | |||
There was a problem hiding this comment.
getHTML() is specific to HTML:
Suggested change
| group: dom | |
| group: html |
There was a problem hiding this comment.
Can you elaborate on this one a bit? I thought of this as "fancy innerHTML," which is part of the basic dom feature. It seemed weird to me that they would be in separate groups.
Co-authored-by: Patrick Brosset <[email protected]>
Co-authored-by: Philip Jägenstedt <[email protected]>
Co-authored-by: Patrick Brosset <[email protected]>
Surprising, but correct.
It's a more generic operation. Co-authored-by: Philip Jägenstedt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a feature for the state-preserving method for moving DOM subtrees,
moveBefore(). While I was here, I created a group for DOM features that operate on the DOM in general. That is, they represent or modify the document tree (rather than represent specific elements or provide other APIs).