Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC 213: Wait for document.fonts.ready before running checkLayout() tests #213

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jonathan-j-lee
Copy link
Contributor

@gsnedders
Copy link
Member

I wonder, without thinking about this much, whether we should use the same logic as reftests (and crashtests, incidentally) use: https://github.com/web-platform-tests/wpt/blob/6c7c4003dba847b63e16083a0b7b8f473d9ad7e1/tools/wptrunner/wptrunner/executors/test-wait.js

Notably, this waits for the load event (and in some browsers this might wait for font loading, c.f. w3c/csswg-drafts#1088), which maybe relevant for rendering when images for example are involved, and then waits for document.fonts.ready and then two further rAFs (which we probably don't need).

@jonathan-j-lee
Copy link
Contributor Author

Reviewing the meeting minutes, @jgraham said:

Removing the installation of fonts should require a RFC.

Just to be clear, this RFC is not proposing the removal of wpt run --install-fonts, which some users might still find useful. This RFC only drops that option from WPT CI.

Assuming we're on the same page about that, I think this RFC is ready to be accepted?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants