Use FilterEntity instead of Filter #3703
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The datastore library has marked Filter as deprecated. By moving to FilterEntity, we can use more advanced queries as well. This commit introduces a new EntityFilter type. That type just wraps datastore.EntityFilter because there are no exposed methods on datastore.EntityFilter for us to manually declare. In order to create an EntityFilter, another type called FilterBuilder is created which will allow consumers to make a particular Filter that reteurns an EntityFilter. More about the deprecation here: https://pkg.go.dev/cloud.google.com/go/datastore#Query.Filter
jcscottiii
force-pushed
the
migrate-from-deprecated-filter
branch
from
aab6a25
to
d1daaf0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The datastore library has marked Filter as deprecated. By moving to FilterEntity, we can use more advanced queries as well.
This commit introduces a new EntityFilter type. That type just wraps datastore.EntityFilter because there are no exposed methods on datastore.EntityFilter for us to manually declare.
In order to create an EntityFilter, another type called FilterBuilder is created which will allow consumers to make a particular Filter that reteurns an EntityFilter.
More about the deprecation here: https://pkg.go.dev/cloud.google.com/go/datastore#Query.Filter