-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Remove the popover
defaultopen
attribute
Per the [1] resolution, we have decided to remove this feature for now, while we work on ways to make it more generic and applicable to other elements such as `<details>` and `<dialog>`. [1] openui/open-ui#631 (comment) Bug: 1307772 Change-Id: I7bc385fcbe1fadfcdf83d2d65c2e46abc07cb8a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4021706 Reviewed-by: Nate Fischer <[email protected]> Auto-Submit: Mason Freed <[email protected]> Commit-Queue: Mason Freed <[email protected]> Reviewed-by: Joey Arhar <[email protected]> Cr-Commit-Position: refs/heads/main@{#1071760}
- Loading branch information
1 parent
d251ba1
commit 3c338f5
Showing
7 changed files
with
40 additions
and
88 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,6 +3,7 @@ | |
<link rel=author href="mailto:[email protected]"> | ||
<link rel=help href="https://open-ui.org/components/popup.research.explainer"> | ||
<link rel=match href="popover-anchor-display-ref.tentative.html"> | ||
<script src="resources/popover-utils.js"></script> | ||
|
||
<p>There should be a green box attached to the right side of each orange box.</p> | ||
|
||
|
@@ -24,6 +25,10 @@ | |
<div id=popover3 popover=manual defaultopen></div> | ||
</div> | ||
|
||
<script> | ||
showDefaultopenPopoversOnLoad(); | ||
</script> | ||
|
||
<style> | ||
.ex { | ||
margin: 25px; | ||
|
24 changes: 0 additions & 24 deletions
24
html/semantics/popovers/popover-defaultopen-2.tentative.html
This file was deleted.
Oops, something went wrong.
6 changes: 0 additions & 6 deletions
6
html/semantics/popovers/popover-defaultopen-display-ref.tentative.html
This file was deleted.
Oops, something went wrong.
14 changes: 0 additions & 14 deletions
14
html/semantics/popovers/popover-defaultopen-display.tentative.html
This file was deleted.
Oops, something went wrong.
44 changes: 0 additions & 44 deletions
44
html/semantics/popovers/popover-defaultopen.tentative.html
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters