Fetch: test Cross-Origin-Resource-Policy: same-site's scheme restriction #11428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
requested review from
domfarolino,
jdm,
mnot,
youennf and
yutakahirano
annevk
added a commit
to whatwg/fetch
that referenced
this pull request
Jun 8, 2018
This header makes it easier for sites to block unwanted "no-cors" cross-origin requests. Tests: * web-platform-tests/wpt#11171 * web-platform-tests/wpt#11427 * web-platform-tests/wpt#11428 Follow-up: #760. Fixes #687.
annevk
force-pushed
the
annevk/corp-scheme-restriction
branch
from
3403f42 to
cd37c77
Compare
mikewest
approved these changes
Jun 18, 2018
| return promise_rejects(t, | ||
| new TypeError(), | ||
| fetch(get_host_info().HTTPS_REMOTE_ORIGIN + "/fetch/cross-origin-resource-policy/resources/hello.py?corp=same-site", { mode: "no-cors" })); | ||
| }, "Cross-Origin-Resource-Policy: same-site's scheme restriction"); |
There was a problem hiding this comment.
Nit: Perhaps name the test "same-site will block an HTTPS resource's inclusion into an HTTP document." for clarity?
annevk
force-pushed
the
annevk/corp-scheme-restriction
branch
from
d3d8a27 to
b8b37d4
Compare
annevk
added a commit
to whatwg/fetch
that referenced
this pull request
Jun 18, 2018
This header makes it easier for sites to block unwanted "no-cors" cross-origin requests. Tests: * web-platform-tests/wpt#11171 * web-platform-tests/wpt#11427 * web-platform-tests/wpt#11428 Follow-up: #760 & #767. Fixes #687.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supplements #11171.
For whatwg/fetch#733.