Mark invokers tests as non-tentative #42664
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
|
I would mark this PR as draft until the spec PR lands. |
|
No need to mark as draft. It just needs a label. |
keithamus
force-pushed
the
mark-invokers-tests-as-non-tentative
branch
from
858bcd8
to
e549cce
Compare
|
It looks like this needs rebasing. |
See related spec PR whatwg/html#9841
keithamus
force-pushed
the
mark-invokers-tests-as-non-tentative
branch
from
e549cce
to
236540a
Compare
|
It's a bit weird to have this in an |
annevk
approved these changes
Nov 8, 2024
There was a problem hiding this comment.
Thanks! These look good and we can land these along with the PR, but I'm assuming that these do not cover the type getter of the button element as we discussed that today. And they might also not cover the command getter in as much detail as is needed? E.g., does it handle OPEN becoming open, blah becoming null, --BLAH staying --BLAH?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See related spec PR whatwg/html#9841