Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WPT for error reporting during custom element upgrade #47632

Merged
merged 1 commit into from
Aug 16, 2024

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Aug 16, 2024

This test currently fails in Chromium. 3/4 subtests fail with:

error event should target definition's global but instead
targets test harness global"

See also: whatwg/dom#1303

Bug: 359909516
Change-Id: I0cc589735d9f8c8ec2c4b55c89aabdb4f7500e17
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5789341
Commit-Queue: Jeremy Roman <[email protected]>
Reviewed-by: Mason Freed <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1342635}

This test currently fails in Chromium. 3/4 subtests fail with:

  error event should target definition's global but instead
  targets test harness global"

See also: whatwg/dom#1303

Bug: 359909516
Change-Id: I0cc589735d9f8c8ec2c4b55c89aabdb4f7500e17
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5789341
Commit-Queue: Jeremy Roman <[email protected]>
Reviewed-by: Mason Freed <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1342635}
Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Chromium project.

@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 88f98a5 into master Aug 16, 2024
16 checks passed
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-5789341 branch August 16, 2024 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants