Reland "WebNN: Flatten adjacent dimensions for GEMM > 4D for DirectML" #48186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a reland of commit 0dfa0868aa787cf6d8a32fca83e37ea422b1d0b4 This CL updates the WPT expected results in `matmul.https.any_gpu-expected.txt` on win11-arm64-rel-tests. Original change's description: > WebNN: Flatten adjacent dimensions for GEMM > 4D for DirectML > > This CL flattens adjacent dimensions for GEMM > 4D because > DML_GEMM_OPERATOR_DESC[1] restricts tensor's rank <= 4. > > [1] https://learn.microsoft.com/en-us/windows/win32/api/directml/ns-directml-dml_gemm_operator_desc > > Bug: 353856233 > Change-Id: Ifbced3d3081594ec6fdefc3a2d381ba675aba7cf > Cq-Include-Trybots: luci.chromium.try:win11-blink-rel > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5810975 > Reviewed-by: ningxin hu <[email protected]> > Commit-Queue: Mingming1 Xu <[email protected]> > Reviewed-by: Rafael Cintron <[email protected]> > Cr-Commit-Position: refs/heads/main@{#1354311} Bug: 353856233 Change-Id: Ia2ae737316d2a328275bdc6063b86b9b0888b51f Cq-Include-Trybots: luci.chromium.try:win11-blink-rel, mac14.arm64-blink-rel, mac14-blink-rel, mac15.arm64-blink-rel, mac15-blink-rel, linux-blink-rel Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5858369 Reviewed-by: Rafael Cintron <[email protected]> Reviewed-by: ningxin hu <[email protected]> Commit-Queue: Mingming1 Xu <[email protected]> Cr-Commit-Position: refs/heads/main@{#1355556}
wpt-pr-bot
approved these changes
Sep 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a reland of commit 0dfa0868aa787cf6d8a32fca83e37ea422b1d0b4
This CL updates the WPT expected results in
matmul.https.any_gpu-expected.txton win11-arm64-rel-tests.Original change's description:
Bug: 353856233
Change-Id: Ia2ae737316d2a328275bdc6063b86b9b0888b51f
Cq-Include-Trybots: luci.chromium.try:win11-blink-rel, mac14.arm64-blink-rel, mac14-blink-rel, mac15.arm64-blink-rel, mac15-blink-rel, linux-blink-rel
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5858369
Reviewed-by: Rafael Cintron <[email protected]>
Reviewed-by: ningxin hu <[email protected]>
Commit-Queue: Mingming1 Xu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1355556}