[css-flexbox] incorrect layout with max-height and flex-direction col… #49219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…umn and justify-content center Safarii/WebKitGTK currently makes this flex item 200px tall. Firefox and Chrome give it the correct height of 100px. WebKit does not adjust the inner flex size to the max size specified in the outer flex container. After calculation of the flex item size and adjusting it to min/max size of the flex item WebKit should also check how the calculated size corresponds to specified max size of the whole container. In case the adjusted flex item size is bigger than the max size of the whole container WebKit should use the flex item size calculated before adjusting to flex item min/max size.
wpt-pr-bot
requested review from
cbiesinger,
fantasai,
kojiishi,
plinss,
rachelandrew and
tabatkins
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…umn and justify-content center
Safarii/WebKitGTK currently makes this flex item 200px tall. Firefox and Chrome give it the correct height of 100px.
WebKit does not adjust the inner flex size to the max size specified in the outer flex container.
After calculation of the flex item size and adjusting it to min/max size of the flex item WebKit should also check how the calculated size corresponds to specified max size of the whole container. In case the adjusted flex item size is bigger than the max size of the whole container WebKit should use the flex item size calculated before adjusting to flex item min/max size.