Reland "Add tests of events for customizable select" #49279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a reland of commit 86eb111c7cd216df5bc6e896256795e420d1bf99
The original patch is listed in patchset 1. The failures were caused by flakiness in the failure mode in two cases:
1. The two virtual suites. Other similar failures for other tests
are listed in TestExpectations, so this patch now does that.
2. Headless causes problems and flakiness.
Original change's description:
> Add tests of events for customizable select
>
> This adds a test that looks at the event behavior of select,
> particularly for interactions that open and close the picker,
> and select options.
>
> Change-Id: I5238360cecc83b48b0f8143380018d4781d65c72
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6006480
> Commit-Queue: Joey Arhar <[email protected]>
> Reviewed-by: Joey Arhar <[email protected]>
> Auto-Submit: Mason Freed <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1383214}
Change-Id: I243e92e889a44ae2cc459d4efb8a0bbfbe79cc51
Bug: 379669748
Change-Id: I243e92e889a44ae2cc459d4efb8a0bbfbe79cc51
Fixed: 379168836
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6032572
Reviewed-by: Joey Arhar <[email protected]>
Commit-Queue: Joey Arhar <[email protected]>
Auto-Submit: Mason Freed <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1386900}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-6032572
branch
from
af73198
to
5ff581d
Compare
wpt-pr-bot
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a reland of commit 86eb111c7cd216df5bc6e896256795e420d1bf99
The original patch is listed in patchset 1. The failures were caused by flakiness in the failure mode in two cases:
are listed in TestExpectations, so this patch now does that.
Original change's description:
Change-Id: I243e92e889a44ae2cc459d4efb8a0bbfbe79cc51
Bug: 379669748
Change-Id: I243e92e889a44ae2cc459d4efb8a0bbfbe79cc51
Fixed: 379168836
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6032572
Reviewed-by: Joey Arhar <[email protected]>
Commit-Queue: Joey Arhar <[email protected]>
Auto-Submit: Mason Freed <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1386900}