Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace all __metaclass__ usage #49284

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Replace all __metaclass__ usage #49284

wants to merge 1 commit into from
+39 −82

Conversation

gsnedders
Copy link
Member

All of these haven't actually been metaclasses since we moved to Python 3; we should fix that.

@gsnedders
Replace all __metaclass__ usage
c6adbae 
All of these haven't actually been metaclasses since we moved to
Python 3; we should fix that.
@wpt-pr-bot wpt-pr-bot added infra wptrunner The automated test runner, commonly called through ./wpt run labels Nov 20, 2024
@gsnedders
Copy link
Member Author

Ah, mypy is failing to catch this, so it's only getting caught at initiation time. That's unfortunate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielRyanSmith DanielRyanSmith Awaiting requested review from DanielRyanSmith

@foolip foolip Awaiting requested review from foolip

@jgraham jgraham Awaiting requested review from jgraham

At least 1 approving review is required to merge this pull request.

Assignees

@jgraham jgraham

Labels
infra wptrunner The automated test runner, commonly called through ./wpt run
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gsnedders @jgraham @wpt-pr-bot