-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add bundlesize to CI #3260
Merged
Merged
Add bundlesize to CI #3260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 7, 2019
Merged
nivida
suggested changes
Dec 9, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A great tool you found! LGTM! I've only added two comments about the execution of bundlesize
.
nivida
added
1.x
1.0 related issues
CI
Enhancement
Includes improvements or optimizations
labels
Dec 9, 2019
cgewecke
commented
Dec 9, 2019
cgewecke
commented
Dec 9, 2019
cgewecke
commented
Dec 9, 2019
nivida
approved these changes
Dec 10, 2019
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a bundlesize checker to CI. First stage of plan for the build pipeline per comment 3160.
Service and tool lgtm, they have grant funding from Google Chrome. Added their token in CI to the Travis settings.
There are various config options including the ability to inspect multiple bundles, with and without compression. Chose a single report for the
packages/web3/dist
(uncompressed) because that seemed to give the clearest report. And set the maxSize high for now - can be tightened as size is optimized.Looks like this:
@nivida if you look in the CI build job you'll see a server error from buildsize - it's possible this is because you'll need to authorize the app for Web3? Currently just using a token from my auth.
Type of change
Checklist:
npm run dtslint
with success and extended the tests and types if necessary.npm run test:unit
with success and extended the tests if necessary.npm run build-all
and tested the resulting file/'s fromdist
folder in a browser.CHANGELOG.md
file in the root folder.