Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(web3-eth-accounts): improve _getCommon method implementation #7460

Open
wants to merge 1 commit into
base: 4.x
Choose a base branch
from
Open

refactor(web3-eth-accounts): improve _getCommon method implementation #7460

wants to merge 1 commit into from

Conversation

crStiv
Copy link

@crStiv crStiv commented Feb 10, 2025

Description:

  • Improved type safety in _getCommon method
  • Enhanced handling of custom Common objects
  • Simplified chainId validation logic
  • Removed redundant TODO comments
  • Better error handling for edge cases

jdevcs
jdevcs reviewed Feb 11, 2025
View reviewed changes
Copy link
Contributor

@jdevcs jdevcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contributions. we are in the process of sunsetting Web3.js, Our focus during this transition will be on addressing only critical issues to ensure a smooth migration for our users.
For further details regarding the sunsetting of Web3.js, please refer to the official announcement here: Web3.js Sunset Announcement

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdevcs jdevcs jdevcs left review comments

@AlexeyKrasnoperov AlexeyKrasnoperov Awaiting requested review from AlexeyKrasnoperov AlexeyKrasnoperov is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@crStiv @jdevcs