[test] Test issued when the fund contract receives a donation #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please tell me what you think of the pr. @adrianvrj @EmmanuelAR ⛩️🚀⌨️ |
EmmanuelAR
requested changes
Nov 1, 2024
contracts/tests/test_fund.cairo
Outdated
|
|
||
| #[test] | ||
| #[fork("Mainnet")] | ||
| fn test_donation_received() { |
There was a problem hiding this comment.
Please change this method name for someone more specific like this:
test_emit_event_donation_received()
EmmanuelAR
approved these changes
Nov 1, 2024
EmmanuelAR
requested changes
Nov 1, 2024
adrianvrj
requested changes
Nov 1, 2024
contracts/README.md
Outdated
| ```bash | ||
| export PATH="$HOME/.local/bin:$PATH" | ||
| ``` | ||
| It is recommended to recharge the terminal. |
There was a problem hiding this comment.
Change recharge for restart please
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Changes description
These tests verify that issue 183 #138 is correctly executed and make sure that the event emits the expected values, the tests pass successfully.
Current output
Comments
I hope the solution solves what you requested, please let me know of any changes I need to make. Best regards.