Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Python bindings for jsartoolkitNFT #431

Open
wants to merge 24 commits into
base: dev
Choose a base branch
from
Open

Conversation

kalwalt
Copy link
Member

@kalwalt kalwalt commented Feb 21, 2025

Python bindings for JsartoolkitNFT

In this PR i want to develop python bindings for jsartoolkitNFT. Of course, this means i will not transpile typescript/javascript code to python, instead i created C++ glue code to use with setuptools and pybind11, so creating python binding code.
There are some issues and i will list here to take note and solve them.
Most of the methods in ArtoolKitNFT_py.cpp are transpiled to python, the getNFTMarkerInfo is not yet implemented. i have not a clear idea on how is better deal the object that return as in the C++ code for emscripten and convert to python.
In this PR i will only propose some small tests, instead of a complete wrapper.

Issues and tasks to solve

  • ARLOG doesn't add a return character so all logs are scrambled lines. Solved with commit fcab895 and a0d4d8d
  • getKpmImageWidth and getKpmImageHeight cause compilations errors, so i excluded both from the build process.
  • getNFTMarkerInfo need to be implemented
  • issue in include/AR/config.h at line 540 (excluded #error option)
  • github action to test the python build process
  • improved tests with python unittest
  • test python package on testpy

@kalwalt kalwalt added enhancement New feature or request C/C++ labels Feb 21, 2025
@kalwalt kalwalt self-assigned this Feb 21, 2025
…sing vcpkg and streamline include/library directories
@kalwalt
Copy link
Member Author

kalwalt commented Feb 24, 2025

Now the project can be build for both Linux and Windows OS's, it can be improved but it is an important step!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant