Fix/record is not a data record

package.json

@@ -1,6 +1,6 @@
 {
     "name": "@bambooapp/bamboo-molecules",
-    "version": "0.3.23",
+    "version": "0.3.24",
     "repository": {
         "type": "git",
         "url": "git+https://github.com/webbeetechnologies/bamboo-molecules.git"

src/datagrid/hooks/useHandleKeydownEvents.tsx

@@ -12,7 +12,7 @@ import {
     usePluginsDataStoreRef,
 } from '../plugins';
 import { useNormalizeSelectionHandler } from '../plugins/utils';
-import { isDataRow, GroupRecord, getRecordByIndex } from '../utils';
+import { GroupRecord, getRecordByIndex } from '../utils';
 import type { TableManagerContextType } from '../contexts/TableManagerContext';
 
 export type Props = {
@@ -67,6 +67,7 @@ const useHandleKeydownEvents = ({ ref }: Props) => {
             const continuePaste = beforePasteCell({
                 selection,
             });
+
             if (osKeyMap.paste && continuePaste !== false) {
                 onPasteCell({
                     selection: normalizeSelectionForGrouping(selection, tableManagerStore),
@@ -102,19 +103,18 @@ const normalizeSelectionForGrouping = (
     store: React.MutableRefObject<TableManagerContextType>,
 ) => {
     // Normalize selection in case of grouping
-    const getRowData = (index: number): GroupRecord => {
-        const record = getRecordByIndex(store.current.records, index);
-        if (!isDataRow(record)) throw new Error('Record is not a data row');
-        return record;
-    };
+    const getRowData = (index: number) =>
+        getRecordByIndex(store.current.records, index) as GroupRecord;
 
     const {
         index: startIndex,
-        indexInGroup: startRowIndexInGroup,
+        indexInGroup: startRowIndexInGroup = startIndex,
         groupConstants,
     } = getRowData(start.rowIndex);
 
-    const { index: endIndex, indexInGroup: endRowIndexInGroup } = getRowData(end.rowIndex);
+    const { index: endIndex, indexInGroup: endRowIndexInGroup = endIndex } = getRowData(
+        end.rowIndex,
+    );
 
     return {
         ...rest,

src/datagrid/plugins/cell-focus/useSetFocusCellPluginStore.tsx

@@ -47,7 +47,9 @@ export const useSetFocusCellPluginStore = () => {
             if (focusedCell === null) {
                 const shouldContinue = beforeUnFocusCell({
                     cell: pluginsStoreRef.current[CELL_FOCUS_PLUGIN_KEY]?.focusedCell
-                        ? normalizeCell(pluginsStoreRef.current[CELL_FOCUS_PLUGIN_KEY]?.focusedCell)
+                        ? normalizeCell(
+                              pluginsStoreRef.current[CELL_FOCUS_PLUGIN_KEY]?.focusedCell,
+                          ) ?? null
                         : null,
                 });
 

src/datagrid/plugins/cell-selection.tsx

@@ -114,7 +114,7 @@ const useOnDragAndSelectStart = () => {
                 [CELL_SELECTION_PLUGIN_KEY]: {
                     ...prev[CELL_SELECTION_PLUGIN_KEY],
                     start: normalizeCell(cell),
-                    isSelecting: true,
+                    isSelecting: !!normalizeCell(cell),
                 },
             }));
         },

src/datagrid/plugins/drag-and-extend.tsx

@@ -58,7 +58,7 @@ const useOnDragEnd = () => {
 
         if (!start && !end) return;
 
-        if (!start || !end) {
+        if (!start || !end || !normalizeCell(start) || !normalizeCell(end)) {
             setPluginsDataStore(() => ({
                 [DRAG_AND_EXTEND_PLUGIN_KEY]: undefined,
             }));

src/datagrid/plugins/plugins-manager.tsx

@@ -38,7 +38,7 @@ const defaultPlugins = [] as PluginsManagerContextType['plugins'];
 const defaultContextValue = {};
 
 const withPluginsData =
-    <P,>(Component: ComponentType<P>) =>
+    <P extends {}>(Component: ComponentType<P>) =>
     (props: P) => {
         return (
             <PluginsDataContextProvider value={defaultContextValue}>

src/datagrid/plugins/utils/useNormalizeCellHandler.tsx

@@ -24,27 +24,32 @@ const useNormalizeCellHandler = () => {
             const getDataRow = (index: number) => {
                 const record = getRecordByIndex(tableManagerStore.current.records, index);
                 if (!isDataRow(record)) throw new Error('Record is not a data row');
+
                 return record;
             };
 
-            const record = getDataRow(rowIndex);
+            try {
+                const record = getDataRow(rowIndex);
 
-            // Drop row id entirely. Let the component consumer be responsible for clearing the state when records are removed.
-            // // for the case when the record is deleted
-            // if (!rowId && !record.id) return undefined;
+                // Drop row id entirely. Let the component consumer be responsible for clearing the state when records are removed.
+                // // for the case when the record is deleted
+                // if (!rowId && !record.id) return undefined;
 
-            // for focused cell, we can't just check the indices, we have to check with the ids to see if it exists or not
-            // it's allowed for the record to be undefined thus we do not check for rowId.
-            if (columnId && dataTableStore.current.columns[columnIndex] !== columnId)
-                return undefined;
+                // for focused cell, we can't just check the indices, we have to check with the ids to see if it exists or not
+                // it's allowed for the record to be undefined thus we do not check for rowId.
+                if (columnId && dataTableStore.current.columns[columnIndex] !== columnId)
+                    return undefined;
 
-            return {
-                columnIndex,
-                rowIndex: record.index,
-                rowId: rowId ?? tableManagerStore.current.getRowId(rowIndex) ?? record.id,
-                record,
-                columnId: dataTableStore.current.columns[columnIndex],
-            };
+                return {
+                    columnIndex,
+                    rowIndex: record.index,
+                    rowId: rowId ?? tableManagerStore.current.getRowId(rowIndex) ?? record.id,
+                    record,
+                    columnId: dataTableStore.current.columns[columnIndex],
+                };
+            } catch {
+                return;
+            }
         },
         [tableManagerStore, dataTableStore],
     );