Feature/progress indicator #43
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shashank1010
requested changes
Dec 10, 2022
shashank1010
requested changes
Dec 13, 2022
thetaungg
requested changes
Dec 13, 2022
|
|
||
| return ( | ||
| <View style={containerStyle} onLayout={handleLayout}> | ||
| <Svg width="100%" height="100%" style={progressStyle}> |
There was a problem hiding this comment.
does this work on the mobile?
need to check
added 6 commits
December 21, 2022 13:16
… component completely to have different animation
…progressindicator
shashank1010
requested changes
Dec 22, 2022
| }, | ||
| }; | ||
|
|
||
| export const Circular: ComponentStory<typeof CircularExample> = args => ( |
There was a problem hiding this comment.
CircularExample has props
animatedValuetrackColor- not required for circularvisible- doesn't do anything
Also, What is the use for indeterminateMaxWidth in Circular indicator?
| }, [animationScale, progress, progressAnim]); | ||
|
|
||
| // if it's indeterminate state, we want to use ActivityIndicator instead | ||
| if (indeterminate) |
There was a problem hiding this comment.
return fast.
If indeterminate.. the rest of the computations can be skipped.
| import { default as CircularProgressIndicator } from './Circular'; | ||
|
|
||
| export const ProgressIndicator = Object.assign( | ||
| // @component ./Checkbox.tsx |
| new Array(frames), | ||
| (_, frameIndex) => frameIndex / (frames - 1), | ||
| ); | ||
| const outputRange = Array.from(new Array(frames), (_, frameIndex) => { |
There was a problem hiding this comment.
needs to be broken down into a separate function and be memoized.
You are creating this range over and over again.. every time the component is rendered. or for example color changes..
| } | ||
|
|
||
| // Animate progress bar | ||
| if (indeterminate) { |
There was a problem hiding this comment.
could be broken down into a separate component
| accessibilityValue: indeterminate ? {} : { min: 0, max: 100, now: progress * 100 }, | ||
| containerStyle: container, | ||
| animatedContainerStyle: [animatedContainer, { opacity: fade }, restStyle], | ||
| progressBarStyle: [ |
There was a problem hiding this comment.
can be abstracted into a separate useMemo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.