tests: added timepicker interaction tests #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shashank1010
requested changes
Dec 26, 2022
| await delay(500); | ||
|
|
||
| // type in 60 | ||
| await userEvent.type(canvas.getByTestId('timePickerInteractions-minute-input-plain'), '60'); |
There was a problem hiding this comment.
While this works, this doesn't verify anything.
Does it test AM/PM values?
Does it test 24 hours mode?
Try this use case..
With the current time 11:00AM.. start making it 60 minutes.
everytime the hour updates.. add a 6 before the 0 in the minutes section.. hours would update; in this case it is the expected behaviour..
but see what happens when it hits 11:00 AM after a full circle..
It will crash..
Our test cases should find bugs like these..
Think about all the possible scenarios..
Whatever is wrapped in an if condition.. is a code branch. every code branch is an error waiting to happen.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.