Add timer settings #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fixed tailwind class order
* Handle updating values * Add reducer * Handle data in settings modal
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
blue2wo
reviewed
Jan 24, 2024
Comment on lines
63
to
109
|
|
||
| // import React, { useState } from 'react'; | ||
|
|
||
| // interface PomodoroTimerData { | ||
| // minutes: number; | ||
| // seconds: number; | ||
| // } | ||
|
|
||
| // interface PomodoroTimerSettingsProps { | ||
| // onTimerChange: (updatedTimerData: PomodoroTimerData) => void; | ||
| // } | ||
|
|
||
| // const PomodoroTimerSettings: React.FC<PomodoroTimerSettingsProps> = ({ onTimerChange }) => { | ||
| // const [timerData, setTimerData] = useState<PomodoroTimerData>({ minutes: 25, seconds: 0 }); | ||
|
|
||
| // const handleTimerChange = (callback: (prevSelectedTime: PomodoroTimerData) => Partial<PomodoroTimerData>) => { | ||
| // const updatedProperties = callback(timerData); | ||
| // setTimerData(prevTimerData => ({ ...prevTimerData, ...updatedProperties })); | ||
| // onTimerChange({ ...timerData, ...updatedProperties }); | ||
| // }; | ||
|
|
||
| // const handleMinutesChange = (event: React.ChangeEvent<HTMLInputElement>) => { | ||
| // const minutes = parseInt(event.target.value, 10) || 0; | ||
| // handleTimerChange(prevSelectedTime => ({ minutes })); | ||
| // }; | ||
|
|
||
| // const handleSecondsChange = (event: React.ChangeEvent<HTMLInputElement>) => { | ||
| // const seconds = parseInt(event.target.value, 10) || 0; | ||
| // handleTimerChange(prevSelectedTime => ({ seconds })); | ||
| // }; | ||
|
|
||
| // return ( | ||
| // <div> | ||
| // <label> | ||
| // Minutes: | ||
| // <input type="number" value={timerData.minutes} onChange={handleMinutesChange} /> | ||
| // </label> | ||
| // <br /> | ||
| // <label> | ||
| // Seconds: | ||
| // <input type="number" value={timerData.seconds} onChange={handleSecondsChange} /> | ||
| // </label> | ||
| // </div> | ||
| // ); | ||
| // }; | ||
|
|
||
| // export default PomodoroTimerSettings; |
There was a problem hiding this comment.
Are we needing this anymore?
There was a problem hiding this comment.
@blue2wo oh nope! I will remove that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Related issue: #23
We want users to have the ability to change the length of their designated
pomodoro,short break, andlong breaktimed sessions. This PR adds a module in the settings menu for doing just that.How to test
Screenshots
mobile:
desktop:
