Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update service for WDIO v9 #533

Closed
7 tasks done
goosewobbler opened this issue Apr 18, 2024 · 14 comments · Fixed by #666, #623 or #729
Closed
7 tasks done

Update service for WDIO v9 #533

goosewobbler opened this issue Apr 18, 2024 · 14 comments · Fixed by #666, #623 or #729
Assignees
Labels
CI dependencies documentation Improvements or additions to documentation tooling
Milestone

Comments

@goosewobbler
Copy link
Member

goosewobbler commented Apr 18, 2024

WDIO v9 is coming along nicely, there is a bit of work to do in the service around this, since we are dropping Node 16 I think we cut a major version and punt the IPC bridge replacement to v8.

Tasks:

  • Publish working pre-release builds
  • Ensure dev docs are up to date
  • Manual test with wdio-electron-service-example
  • Manual test with electron-boilerplate (can use the v9 branch)
  • Update WDIO peerdep range to ">9.0.0" (after the WDIO v9 release)
  • Update WDIO deps to "^9.0.0" (after the WDIO v9 release)
  • Publish full release

webdriverio/webdriverio#10362

@seanpoulter
Copy link
Contributor

Is the plan to make a v8 branch and keep v9 development on main?

@goosewobbler
Copy link
Member Author

goosewobbler commented Apr 18, 2024

Yes, I'd have the WDIO v9 version on main which corresponds to v7 of the service. I'd probably name the legacy version branch wdio-v8 or v6 to avoid confusion as the service major versions don't match the WDIO ones. I'm not planning on backporting anything at the moment, but it could be useful to keep around. I don't think WDIO v9 will affect the service anywhere near as much as previous major versions did.

@goosewobbler goosewobbler added this to the 7.0.0 milestone Apr 18, 2024
@goosewobbler goosewobbler self-assigned this Jul 9, 2024
@goosewobbler goosewobbler removed the good first issue Good for newcomers label Jul 9, 2024
@goosewobbler
Copy link
Member Author

goosewobbler commented Jul 9, 2024

I created the wdio-v8 branch in case we need to backport anything to 6.x.

main will require WDIO v9 when #443 and #666 are merged, and will be released as v7.

@goosewobbler goosewobbler linked a pull request Jul 10, 2024 that will close this issue
21 tasks
@goosewobbler goosewobbler reopened this Jul 16, 2024
@goosewobbler
Copy link
Member Author

Re-opened to keep track of the remaining tasks for the release.

@goosewobbler goosewobbler added documentation Improvements or additions to documentation tooling labels Jul 22, 2024
@goosewobbler
Copy link
Member Author

goosewobbler commented Jul 23, 2024

@christian-bromann
I need to publish the dependent packages to get the pre-releases for the service working, I was considering to publish them as @wdio-electron/types and @wdio-electron/utils for which we need the @wdio-electron org; I was going to create this org but thought I'd check first, maybe you should create it and I can join.

Or perhaps publishing them under the main org as @wdio/electron-types and @wdio/electron-utils is better?

@christian-bromann
Copy link
Contributor

Or perhaps publishing them under the main org as @wdio/electron-types and @wdio/electron-utils is better?

Yes, no need to create another org, let's use @wdio/ to which you can publish to through the bot.

@goosewobbler
Copy link
Member Author

Finally got a working pre-release in 7.0.0-beta.9. Tested in wdio-electron-service-example.

@goosewobbler goosewobbler linked a pull request Aug 19, 2024 that will close this issue
@goosewobbler
Copy link
Member Author

electron-boilerplate is still broken on v9 branch, I'll release anyway as the service works in wdio-electron-service-example.

@christian-bromann
Copy link
Contributor

Let me take a look at the boilerplate, I will ping you if I don't know what is going on.

@christian-bromann
Copy link
Contributor

It seems like 7.0.0-beta.11 didn't get pushed to NPM 🤔 However I got the boilerplate working with 7.0.0-beta.10 (there was a bug in Stencil that I fixed but which hasn't been released yet, so reverting that version to v4.18.3 fixed the build).

@goosewobbler
Copy link
Member Author

goosewobbler commented Aug 20, 2024

There's still something up with the release and pre-release workflows, maybe the dry run is creating tags for some reason...

https://github.com/webdriverio-community/wdio-electron-service/actions/runs/10463303622/job/28975088177
https://github.com/webdriverio-community/wdio-electron-service/actions/runs/10462686326/job/28973369345

@goosewobbler
Copy link
Member Author

Reverted to beta.11 and deleted the unused 7.0.0 tag on github, this time I went straight for the full release instead of a dry run followed by full release, it just attempted to release beta.11 again (instead of 7.0.0) 🤔

https://github.com/webdriverio-community/wdio-electron-service/actions/runs/10463968883/job/28976808705

@goosewobbler
Copy link
Member Author

Reopening until we get the full release done, I think we're missing some steps from the release-it monorepo recipe:

https://github.com/release-it/release-it/blob/main/docs/recipes/monorepo.md

@goosewobbler
Copy link
Member Author

goosewobbler commented Aug 21, 2024

Release is done, just need to update electron-boilerplate.

Raised webdriverio/electron-boilerplate#224

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment