Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add dark theme #643

Closed
wants to merge 2 commits into from
Closed

feat: Add dark theme #643

wants to merge 2 commits into from

Conversation

dsshard
Copy link

@dsshard dsshard commented Oct 21, 2024

Add simple dark theme

  • Update readme
  • Add optional param for webpack plugin
  • Add cli flag

@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Oct 21, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@dsshard dsshard changed the title Add dark theme feat: Add dark theme Oct 21, 2024
@dsshard dsshard mentioned this pull request Oct 21, 2024
Open
@valscion
Copy link
Member

valscion commented Nov 14, 2024 •
edited
Loading

Thanks for the PR and the idea! See #642 (comment) for how dark/light mode option could work. Let's keep the design discussion in there and once there is code to look at, I can review it when I have a good time slot for it.

I'll close this PR for now. Feel free to open a new one without a CLI/plugin option as discussed in #642 later if you still want to work on this.

@valscion valscion closed this Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dsshard @valscion