Throw for duplicate package names (closes #339)

webpro-nl · Nov 28, 2023 · 6ad4ced · 6ad4ced
1 parent c7234b7
commit 6ad4ced
Showing 1 changed file with 12 additions and 2 deletions.
diff --git a/packages/knip/src/ConfigurationChief.ts b/packages/knip/src/ConfigurationChief.ts
@@ -1,6 +1,6 @@
 import { existsSync } from 'node:fs';
 import mapWorkspaces from '@npmcli/map-workspaces';
-import { createPkgGraph } from '@pnpm/workspace.pkgs-graph';
+import { createPkgGraph, type Manifest } from '@pnpm/workspace.pkgs-graph';
 import micromatch from 'micromatch';
 import { ConfigurationValidator } from './ConfigurationValidator.js';
 import { ROOT_WORKSPACE_NAME, DEFAULT_EXTENSIONS, KNIP_CONFIG_LOCATIONS } from './constants.js';
@@ -246,7 +246,7 @@ export class ConfigurationChief {
       .map(dir => join(this.cwd, dir));
 
     this.availableWorkspaceManifests = this.getAvailableWorkspaceManifests(this.availableWorkspaceDirs);
-    this.availableWorkspacePkgNames = new Set(this.availableWorkspaceManifests.map(w => w.manifest.name));
+    this.availableWorkspacePkgNames = this.getAvailableWorkspacePkgNames(this.availableWorkspaceManifests);
     this.workspacesGraph = createPkgGraph(this.availableWorkspaceManifests);
     this.enabledWorkspaces = this.getEnabledWorkspaces();
   }
@@ -316,6 +316,16 @@ export class ConfigurationChief {
     });
   }
 
+  private getAvailableWorkspacePkgNames(availableWorkspaceManifests: { dir: string; manifest: PackageJson }[]) {
+    const pkgNames = new Set<string>();
+    for (const { dir, manifest } of availableWorkspaceManifests) {
+      if (!manifest.name) throw new ConfigurationError(`Missing package name in ${join(dir, 'package.json')}`);
+      if (pkgNames.has(manifest.name)) throw new ConfigurationError(`Duplicate package name: ${manifest.name}`);
+      pkgNames.add(manifest.name);
+    }
+    return pkgNames;
+  }
+
   private getEnabledWorkspaces() {
     if (workspaceArg && !existsSync(workspaceArg)) {
       throw new ConfigurationError(`Directory does not exist: ${workspaceArg}`);