fix(plugin/babel): bypass directly required plugins or presets in bab…

…el config (#590)
webpro-nl · Apr 9, 2024 · 77329af · 77329af
1 parent dbcc599
commit 77329af
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/packages/knip/fixtures/plugins/babel/.babelrc.js b/packages/knip/fixtures/plugins/babel/.babelrc.js
@@ -37,6 +37,8 @@ const config = {
         },
       },
     ],
+    // Simulates a required plugin, should not be added to the unspecified plugins array
+    function myCustomPlugin() {}
   ],
 };
 

diff --git a/packages/knip/src/plugins/babel/index.ts b/packages/knip/src/plugins/babel/index.ts
@@ -16,7 +16,7 @@ const isEnabled: IsPluginEnabled = ({ dependencies }) => hasDependency(dependenc
 const config = ['babel.config.{json,js,cjs,mjs,cts}', '.babelrc.{json,js,cjs,mjs,cts}', '.babelrc', 'package.json'];
 
 const getName = (value: string | [string, unknown]) =>
-  typeof value === 'string' ? [value] : Array.isArray(value) ? [value[0]] : [];
+  [Array.isArray(value) ? value[0] : value].filter(name => typeof name === 'string');
 
 export const getDependenciesFromConfig = (config: BabelConfigObj): string[] => {
   const presets = config.presets?.flatMap(getName).map(name => resolveName(name, 'preset')) ?? [];