Refactor binary resolver & referenced dependency handling

.github/workflows/integration.yml

@@ -150,6 +150,5 @@ jobs:
           sparse-checkout: ${{ matrix.project.sparse-checkout }}
 
       - name: Run Knip in ${{ matrix.project.repo }}
-        run: |
-          cd ${{ matrix.project.name }}
-          ${{ matrix.project.commands }}
+        working-directory: ${{ matrix.project.name }}
+        run: ${{ matrix.project.commands }}

packages/docs/scripts/generate-plugin-docs.ts

@@ -10,7 +10,7 @@ import remarkStringify from 'remark-stringify';
 import { unified } from 'unified';
 import type { Node } from 'unist';
 import { u } from 'unist-builder';
-import type { Plugin } from '../../knip/src/types/plugins.js';
+import type { Plugin } from '../../knip/src/types/config.js';
 
 const rootDir = path.join(path.dirname(fileURLToPath(import.meta.url)), '..');
 const referenceDocsDir = path.join(rootDir, 'src/content/docs/reference');
@@ -47,7 +47,7 @@ for await (const dir of directories) {
     const pluginDir = path.join(pluginsDir, pluginName);
     const plugin: Plugin = (await import(path.join(pluginDir, 'index.ts'))).default;
 
-    const { title, enablers, note, config, entry, production, project } = plugin;
+    const { title, enablers, note, args, config, entry, production, project } = plugin;
 
     plugins.push([title, pluginName]);
 
@@ -59,6 +59,8 @@ for await (const dir of directories) {
     if (production && production.length > 0) defaults.entry = [...(defaults.entry ?? []), ...production];
     if (project && project.length > 0) defaults.project = project;
 
+    const hasDefaultConfig = Object.values(defaults).some(v => v.length > 0);
+
     const en =
       Array.isArray(enablers) && enablers.length > 0
         ? [
@@ -78,19 +80,28 @@ for await (const dir of directories) {
 
     const n = note ? [u('heading', { depth: 2 }, [u('text', 'Note')]), ...parseFragment(note)] : [];
 
+    const def = hasDefaultConfig
+      ? [
+          u('heading', { depth: 2 }, [u('text', 'Default configuration')]),
+          ...parseFragment('This configuration is added automatically if the plugin is enabled:'),
+          u('code', {
+            lang: 'json title="knip.json"', // TODO How to set attributes/properties/props properly?
+            value: JSON.stringify({ [pluginName]: defaults }, null, 2),
+          }),
+          ...parseFragment('Your custom `config` or `entry` options override default values, they are not merged.'),
+          ...parseFragment('See [Plugins](../../explanations/plugins) for more details.'),
+        ]
+      : [];
+
+    const argsText = args ? parseFragment('## Shell commands\n\nThis plugin enables argument parsing') : [];
+
     const tree = u('root', [
       frontmatter,
       u('heading', { depth: 2 }, [u('text', 'Enabled')]),
       ...en,
       ...n,
-      u('heading', { depth: 2 }, [u('text', 'Default configuration')]),
-      ...parseFragment('This configuration is added automatically if the plugin is enabled:'),
-      u('code', {
-        lang: 'json title="knip.json"', // TODO How to set attributes/properties/props properly?
-        value: JSON.stringify({ [pluginName]: defaults }, null, 2),
-      }),
-      ...parseFragment('Your custom `config` or `entry` options override default values, they are not merged.'),
-      ...parseFragment('See [Plugins](../../explanations/plugins) for more details.'),
+      ...def,
+      ...argsText,
     ]);
 
     console.log(`Writing ${pluginName} docs to plugins/${pluginName}.md`);

packages/docs/src/content/docs/guides/writing-a-plugin.md

@@ -87,9 +87,9 @@ configuration object.
 Here's the full source code of the `nyc` plugin:
 
 ```ts
-import { hasDependency } from '#p/util/plugin.js';
+import { hasDependency } from '../../util/plugin.js';
 import type { NycConfig } from './types.js';
-import type { ResolveConfig, IsPluginEnabled } from '#p/types/plugins.js';
+import type { ResolveConfig, IsPluginEnabled } from '../../types/config.js';
 
 const title = 'nyc';
 

packages/knip/fixtures/npm-scripts/.gitignore

@@ -0,0 +1 @@
+dist

packages/knip/fixtures/npm-scripts/package.json

@@ -12,7 +12,9 @@
     "ignore-artifact": "node dist/ignore.js",
     "start": "package",
     "go": "runnable",
-    "go-live": "deploy -r repo_name"
+    "go-live": "deploy -r repo_name",
+    "tsup": "tsup -c tsup.cool.json",
+    "tsuppy": "tsup --config tsup.cool.json"
   },
   "dependencies": {
     "express": "*",
@@ -24,6 +26,7 @@
   "devDependencies": {
     "pm2": "*",
     "nx": "*",
+    "tsup": "*",
     "unused": "*",
     "eslint": "8.28.0",
     "eslint-v6": "npm:[email protected]",
@@ -34,11 +37,6 @@
   },
   "knip": {
     "ignore": "ignore.js",
-    "ignoreBinaries": [
-      "rm",
-      "bash",
-      "deploy",
-      "eslint"
-    ]
+    "ignoreBinaries": ["rm", "bash", "deploy", "eslint"]
   }
 }

packages/knip/fixtures/plugins/github-actions-workspaces/.github/workflows/dir.yml

@@ -0,0 +1,13 @@
+name: CI
+
+on: push
+
+jobs:
+  stylelint:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v4
+      - name: Run stylelint check
+        run: yarn stylelint
+        working-directory: packages/app

packages/knip/fixtures/plugins/github-actions-workspaces/package.json

@@ -0,0 +1,10 @@
+{
+  "name": "@fixtures/github-actions-workspaces",
+  "workspaces": ["packages/*"],
+  "scripts": {
+    "hello-app": "yarn run --cwd packages/app goodbye"
+  },
+  "dependencies": {
+    "hello": "*"
+  }
+}

packages/knip/fixtures/plugins/github-actions-workspaces/packages/app/package.json

@@ -0,0 +1,11 @@
+{
+  "name": "@github-actions-workspaces/app",
+  "scripts": {
+    "stylelint": "stylelint",
+    "hello-world": "yarn run --top-level hello"
+  },
+  "devDependencies": {
+    "stylelint": "*",
+    "goodbye": "*"
+  }
+}

packages/knip/fixtures/plugins/github-actions-workspaces/packages/lib/package.json

@@ -0,0 +1,3 @@
+{
+  "name": "@github-actions-workspaces/lib"
+}

packages/knip/fixtures/plugins/github-actions/.github/workflows/working-directory.yml

@@ -0,0 +1,33 @@
+name: CI
+
+on: push
+
+jobs:
+  job1:
+    runs-on: ubuntu-latest
+    name: work
+
+    steps:
+      - uses: actions/checkout@d632683dd7b4114ad314bca15554477dd762a938
+
+      - run: node scripts/no-working-dir
+
+  job2:
+    runs-on: ubuntu-latest
+
+    steps:
+      - uses: actions/checkout@4
+        with:
+          path: some-dir
+
+      - run: node scripts/from-working-dir-with-path
+        working-directory: ./some-dir
+
+  job3:
+    runs-on: ubuntu-latest
+
+    steps:
+      - uses: actions/checkout@4
+
+      - run: node from-working-dir
+        working-directory: scripts

packages/knip/fixtures/plugins/node/package.json

@@ -0,0 +1,4 @@
+{
+  "name": "@fixtures/node",
+  "version": "*"
+}

packages/knip/fixtures/plugins/nodemon/package.json

@@ -0,0 +1,4 @@
+{
+  "name": "@fixtures/nodemon",
+  "version": "*"
+}

packages/knip/fixtures/plugins/tsup/package.json

@@ -1,4 +1,15 @@
 {
   "name": "@fixtures/tsup",
-  "version": "*"
+  "version": "*",
+  "devDependencies": {
+    "tsup": "*"
+  },
+  "scripts": {
+    "build": "tsup",
+    "build-3": "tsup --config tsup.config-3.ts",
+    "build-4": "tsup -c tsup.config-4.ts"
+  },
+  "tsup": {
+    "entry": ["entry-5.ts"]
+  }
 }

packages/knip/fixtures/plugins/tsup/tsup.config-3.ts

@@ -0,0 +1,5 @@
+import { defineConfig } from 'tsup';
+
+export default defineConfig({
+  entry: ['entry-3.ts'],
+});

packages/knip/fixtures/plugins/tsup/tsup.config-4.ts

@@ -0,0 +1,5 @@
+import { defineConfig } from 'tsup';
+
+export default defineConfig({
+  entry: ['entry-4.ts'],
+});

packages/knip/fixtures/plugins/tsup/tsup.config.json

@@ -0,0 +1,3 @@
+{
+  "entry": ["entry-1.ts"]
+}

packages/knip/fixtures/plugins/tsup/tsup.config.ts

@@ -0,0 +1,5 @@
+import { defineConfig } from 'tsup';
+
+export default defineConfig({
+  entry: ['entry-2.ts'],
+});

packages/knip/fixtures/plugins/typescript/package.json

@@ -1,5 +1,12 @@
 {
   "name": "@fixtures/typescript",
+  "scripts": {
+    "build-base": "tsc -p tsconfig.base.json",
+    "build-ext": "tsc -p tsconfig.ext.json",
+    "build-preact": "tsc -p tsconfig.jsx-import-source-preact.json",
+    "build-react": "tsc -p tsconfig.jsx-import-source-react.json",
+    "build-jsx": "tsc -p tsconfig.jsx-preserve.json"
+  },
   "devDependencies": {
     "typescript": "*"
   }

packages/knip/fixtures/plugins/vitest6/config/fiep.ts

@@ -0,0 +1,9 @@
+import { defineConfig } from 'vitest/config';
+
+export default defineConfig({
+  test: {
+    root: '../tests',
+    include: ['*.test.ts'],
+    setupFiles: ['./setup.ts'],
+  },
+});

packages/knip/fixtures/plugins/vitest6/package.json

@@ -0,0 +1,9 @@
+{
+  "name": "@fixtures/vitest6",
+  "scripts": {
+    "test": "vitest -c config/fiep.ts"
+  },
+  "devDependencies": {
+    "vitest": "*"
+  }
+}

packages/knip/fixtures/plugins/vitest6/src/unused.test.ts

@@ -0,0 +1,5 @@
+import { expect, test } from 'vitest';
+
+test('Unit A', () => {
+  expect(true).toBe(!false);
+});

packages/knip/fixtures/plugins/vitest6/tests/adder.test.ts

@@ -0,0 +1,5 @@
+import { expect, test } from 'vitest';
+
+test('Unit A', () => {
+  expect(true).toBe(!false);
+});

packages/knip/fixtures/plugins/vitest6/tests/setup.ts

@@ -0,0 +1 @@
+export default {};

packages/knip/fixtures/workspaces-plugin-config/packages/backend/config/vitest.config.ts

@@ -2,6 +2,7 @@ import { defineConfig } from 'vitest/config';
 
 export default defineConfig({
   test: {
+    root: '..',
     include: ['**/*.vitest.ts'],
     environment: 'node',
   },

packages/knip/fixtures/workspaces-plugin-config/packages/frontend/config/vitest.config.ts

@@ -2,6 +2,7 @@ import { defineProject } from 'vitest/config';
 
 export default defineProject({
   test: {
+    root: '..',
     include: ['**/*.vitest.ts'],
     environment: 'jsdom',
   },

packages/knip/package.json

@@ -35,10 +35,6 @@
   },
   "type": "module",
   "types": "./dist/index.d.ts",
-  "imports": {
-    "#p/*.ts": "./src/*.ts",
-    "#p/*.js": "./dist/*.js"
-  },
   "scripts": {
     "knip": "node ./dist/cli.js --directory ../..",
     "knip:production": "node ./dist/cli.js --directory ../.. --production --strict",
@@ -52,7 +48,8 @@
     "qa": "bun lint && bun run build && bun knip && bun knip:production && bun run test",
     "release": "release-it",
     "create-plugin": "bun ./scripts/create-new-plugin.ts",
-    "postcreate-plugin": "biome format --write schema.json schema-jsonc.json src/ConfigurationValidator.ts"
+    "postcreate-plugin": "biome format --write schema.json schema-jsonc.json src/ConfigurationValidator.ts",
+    "generate-plugin-types": "bun ./scripts/generate-plugin-types.ts"
   },
   "files": [
     "dist",