Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playwright for components plugin #262

Merged
merged 2 commits into from
Sep 24, 2023
Merged

Conversation

jgoux
Copy link
Contributor

@jgoux jgoux commented Sep 23, 2023

Playwright now supports component testing which uses a different config + dependencies: https://playwright.dev/docs/test-components

@webpro
Copy link
Collaborator

webpro commented Sep 23, 2023

Thanks @jgoux, looks like a good addition. Any chance you could add some fixtures and test coverage for this?

@jgoux
Copy link
Contributor Author

jgoux commented Sep 24, 2023

Added fixtures and generated the docs. 👍

@webpro
Copy link
Collaborator

webpro commented Sep 24, 2023

Looked into their docs a bit, what do you think about splitting this up in a separate plugin (e.g. playwright-ct)?

I say this, because when I run npm init playwright@latest -- --ct I only get @playwright/experimental-ct-react so the ENABLERS are also separate dependencies? Didn't actually use CT before, so I'm not sure :)

@jgoux
Copy link
Contributor Author

jgoux commented Sep 24, 2023

Looked into their docs a bit, what do you think about splitting this up in a separate plugin (e.g. playwright-ct)?

I say this, because when I run npm init playwright@latest -- --ct I only get @playwright/experimental-ct-react so the ENABLERS are also separate dependencies? Didn't actually use CT before, so I'm not sure :)

It's pretty new to me as well, I tested removing @playwright/test and indeed it works with only @playwright/experimental-ct-*. I'll make the changes to split it into a new plugin. 👍

@jgoux jgoux reopened this Sep 24, 2023
@jgoux
Copy link
Contributor Author

jgoux commented Sep 24, 2023

The feature is now isolated into its own playwright-ct plugin, and the CI is ✅, I guess it's ready for review @webpro. 😄

@jgoux jgoux changed the title Support for components testing in playwright plugin Playwright for components plugin Sep 24, 2023
@webpro webpro merged commit af3c11b into webpro-nl:main Sep 24, 2023
18 checks passed
@webpro
Copy link
Collaborator

webpro commented Sep 24, 2023

Awesome! Thanks for this, great addition

@webpro
Copy link
Collaborator

webpro commented Sep 24, 2023

🚀 This pull request is included in v2.27.0. See Release 2.27.0 for release notes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants