Use path.relative instead of path.posix.relative for relative paths

[birtles]

On Windows calling:

path.posix.relative('C:/Users/Brian/10ten-ja-reader', '.')

will produce ../../../...

I believe what it does in this case is run path.posix.resolve() on both arguments producing /Users/Brian/C:/Users/Brian/10ten-ja-reader and /Users/Brian and then determines the relative between the two giving us ../../../...

If we use path.relative instead, which does not try to resolve both paths to posix paths first, we get the expected result, an empty string:

If from and to each resolve to the same path (after calling
path.resolve() on each), a zero-length string is returned.

(Source: https://nodejs.org/api/path.html#pathrelativefrom-to)

We'll still probably want to convert the result of that to a posix path using our toPosix helper, in order to be consistent with how we handle paths elsewhere, otherwise we'll get results with backslashes in them.

I've so far only observed an incorrect result coming about from the '.' input and that only from the Playwright plugin so an alternative fix might be to get the Playwright plugin to stop producing relative paths of the form '.' but I suspect this could show up in other places.

[birtles]

Never mind, I saw you just fixed this in birchill/10ten-ja-reader#1359 (comment) 😅

Thank you!

[webpro]

Sorry, beat you by a minute I'm afraid :/

Thanks anyway :)