Add Eleventy data directory as entry pattern

[uncenter]

Closes #453.

[vercel]

Someone is attempting to deploy a commit to a Personal Account owned by @webpro on Vercel.

@webpro first needs to authorize it.

[webpro]

Great, looks good so far but I do have a few comments.

[uncenter]

Will PRODUCTION_ENTRY_FILE_PATTERNS merge with the results of findDependencies?

[webpro]

Will PRODUCTION_ENTRY_FILE_PATTERNS merge with the results of findDependencies?

Not automatically, we'll have to do that inside findDependencies

[uncenter]

I actually think we don't want to that, since it might accidentally count some files as entry files when they really aren't. More "correct" versions of all of the PRODUCTION_ENTRY_FILE_PATTERNS are detectable by findDependencies.

[webpro]

I actually think we don't want to that, since it might accidentally count some files as entry files when they really aren't. More "correct" versions of all of the PRODUCTION_ENTRY_FILE_PATTERNS are detectable by findDependencies.

What about the workspaces that don't have that .eleventy.js file? We'll need fallback values when there's no localConfig to parse, right?

[uncenter]

Ah right, sorry. So maybe if (!localConfig) return PRODUCTION_ENTRY_FILE_PATTERNS instead of if (!localConfig) return []?

[webpro]

Ah right. So maybe if (!localConfig) return PRODUCTION_ENTRY_FILE_PATTERNS instead of if (!localConfig) return []?

Exactly, in that case it should do something like it did without your PR :)

[uncenter]

Done. Anything else?

[webpro]

This is looking great, almost there :)

[uncenter]

Wow that npm run watch tip was very helpful, I tested and verified it works on my website repository as well as the official Eleventy website repository. I've also reverted the change to PRODUCTION_ENTRY_FILE_PATTERNS.

[webpro]

Thanks @uncenter!

By the way, I'm introducing Knip in the ESLint repo (eslint/eslint#18005) and they're using Eleventy for their docs (in the /docs folder). I think it might be interesting for users of Knip + 11ty to look if it's possible to extract out that dependency:

./node_modules/algoliasearch/dist/algoliasearch-lite.esm.browser.js

Knip has function(s) to extract the algoliasearch from this so it does not need to be in ignoreDependencies.

My question is, do you think even trying this could be interesting for more Eleventy users? We don't need to solve it for a single case of course, but if there's more interest we might be able to give it a shot.

But I guess that should not be part of this PR. This PR is ready, right? Happy to merge it :)

[uncenter]

Yep, good to merge!

[uncenter]

And yep, I've actually been working on that! That kind of pattern of passthrough copying files from node_modules is also in the 11ty-website repo. I'll have a go at it in another PR later today.

[webpro]

And yep, I've actually been working on that! That kind of pattern of passthrough copying files from node_modules is also in the 11ty-website repo. I'll have a go at it in another PR later today.

Please don't feel pushed or anything, only if you like to :)

[uncenter]

Entry files are prefixed withentry: and are dependencies just the name of the package with no prefix? Is that right?

[webpro]

Entry files are prefixed withentry: and are dependencies just the name of the package with no prefix? Is that right?

Yes, exactly. When we know for sure in the plugin we're dealing with entry files we can mark them as such. When we don't do that, Knip might still figure it out, but that's more error-prone and slower.

[webpro]

🚀 This pull request is included in v4.0.4. See Release 4.0.4 for release notes.