Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Netlify plugin #466

Merged
merged 9 commits into from
Jan 21, 2024
Merged

Add Netlify plugin #466

merged 9 commits into from
Jan 21, 2024

Conversation

uncenter
Copy link
Contributor

Adds a Netlify plugin!

@uncenter uncenter marked this pull request as ready for review January 20, 2024 03:51
webpro
webpro reviewed Jan 20, 2024
View reviewed changes
Copy link
Member

@webpro webpro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool! Never thought of a plugin like this, I love it. A few comments, but nothing spectacular I guess :)

@uncenter uncenter requested a review from webpro January 20, 2024 17:36
@uncenter
Copy link
Contributor Author

With the addition of this PR we can also now support the .prettierrc.toml extension: https://github.com/webpro/knip/blob/main/packages/knip/src/plugins/prettier/index.ts#L18.

webpro
webpro reviewed Jan 21, 2024
View reviewed changes
@webpro
Copy link
Member

webpro commented Jan 21, 2024

With the addition of this PR we can also now support the .prettierrc.toml extension: https://github.com/webpro/knip/blob/main/packages/knip/src/plugins/prettier/index.ts#L18.

Yes, this is great!

@uncenter uncenter requested a review from webpro January 21, 2024 19:44
@webpro webpro merged commit 3a8fe85 into webpro-nl:main Jan 21, 2024
8 of 11 checks passed
@uncenter uncenter deleted the feat/add-netlify branch January 21, 2024 20:03
@uncenter
Copy link
Contributor Author

Thanks for merging!

@webpro
Copy link
Member

webpro commented Jan 21, 2024

🚀 This pull request is included in v4.2.0. See Release 4.2.0 for release notes.

@webpro
Copy link
Member

webpro commented Jan 21, 2024

Thank you! Very good idea, great execution 🙏

I did minor changes in your work after a major refactoring today, but nothing essential.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webpro webpro Awaiting requested review from webpro

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@uncenter @webpro