Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vitest: add bench file extension as an entry point #601

Closed
wants to merge 0 commits into from
Closed

vitest: add bench file extension as an entry point #601

wants to merge 0 commits into from

Conversation

krhubert
Copy link
Contributor

@krhubert krhubert commented Apr 22, 2024

This PR adds *.bench.(c|m)[jt]s?(x) as an entry point to vitest plugin.

@krhubert krhubert changed the title vitest: add bench file extension vitest: add bench file extension as an entry point Apr 22, 2024
@webpro
Copy link
Collaborator

webpro commented Apr 22, 2024

Thanks! Any chance you could add a matching file to a vitest fixture directory? For some test coverage and to prevent future regressions.

@krhubert
Copy link
Contributor Author

@webpro done! Let me know if I should do anything more.

@webpro
Copy link
Collaborator

webpro commented Apr 22, 2024

When you run the tests one should fail for some files: n assertion that should be increased with 1.

@webpro
Copy link
Collaborator

webpro commented Apr 22, 2024

Please use the project's formatting (e.g. bun format)

@webpro webpro force-pushed the main branch 2 times, most recently from e6b21e6 to 92de411 Compare April 23, 2024 07:30
@webpro webpro closed this Apr 23, 2024
@webpro
Copy link
Collaborator

webpro commented Apr 23, 2024

lol, I totally screwed up this PR (as I was horrendously working in main), but I've rebased the branch into main and you are still the contributor :)

E.g. see https://github.com/webpro/knip/commits/main/

@krhubert
Copy link
Contributor Author

Hey @webpro , no problem, It's fantastic to have this out. Thank you for this project 🙏🏻

@webpro
Copy link
Collaborator

webpro commented Apr 23, 2024

Cool, thanks! This is now published in v5.10.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants