Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cypress): add support for cypress-multi-reporter #726

Merged
merged 10 commits into from
Jul 16, 2024
Merged

feat(cypress): add support for cypress-multi-reporter #726

merged 10 commits into from
Jul 16, 2024

Conversation

aramissennyeydd
Copy link
Contributor

Closes #701

@netlify Netlify
Copy link

netlify bot commented Jul 12, 2024 •
edited
Loading

✅ Deploy Preview for knip canceled.

Name Link
🔨 Latest commit 2614a83
🔍 Latest deploy log https://app.netlify.com/sites/knip/deploys/669600d52c620e000836a15e

webpro
webpro reviewed Jul 12, 2024
View reviewed changes
Copy link
Collaborator

@webpro webpro left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pull request! Looks great, added a few comments. No biggies, just hoping we don't have to pull in the entire cypress dependency.

packages/knip/src/plugins/cypress/helpers.ts Outdated Show resolved Hide resolved
packages/knip/src/plugins/cypress/types.ts Show resolved Hide resolved
packages/knip/test/plugins/cypress-multi-reporter.test.ts Show resolved Hide resolved
@webpro webpro force-pushed the main branch 3 times, most recently from d91d007 to d4121d9 Compare July 12, 2024 06:07
@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Jul 12, 2024 •
edited
Loading

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

commit: 2614a83

knip

npm i https://pkg.pr.new/knip@726

templates

@aramissennyeydd
Copy link
Contributor Author

@webpro I don't think the new test errors are related to this PR, any ideas what's happening here?

@webpro
Copy link
Collaborator

webpro commented Jul 13, 2024

@webpro I don't think the new test errors are related to this PR, any ideas what's happening here?

The tests are stable in my experience, so they should just pass.

I do see some imports having the .ts extension instead of .js.

@aramissennyeydd
fix imports
86e47de 
Signed-off-by: aramissennyeydd <[email protected]>
@aramissennyeydd
Copy link
Contributor Author

@webpro Yup that was it, looks like everything passed once I changed those!

webpro
webpro approved these changes Jul 15, 2024
View reviewed changes
Copy link
Collaborator

@webpro webpro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor thingie, happy to merge either way!

packages/knip/src/plugins/cypress/helpers.ts Show resolved Hide resolved
@aramissennyeydd
Copy link
Contributor Author

🌬️ away with ye type error

@webpro webpro merged commit cdea5b1 into webpro-nl:main Jul 16, 2024
17 checks passed
@webpro
Copy link
Collaborator

webpro commented Jul 16, 2024

Thanks for the efforts, @aramissennyeydd! Appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webpro webpro webpro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[cypress] add support for cypress-multi-reporter
2 participants
@aramissennyeydd @webpro