(PostCSS plugin): Add postcss to used dependencies when using PostCSS with Tailwind CSS
#764
Conversation
|
| Name | Link |
|---|---|
| 🔨 Latest commit | 3cd136f |
|
commit: |
| const resolve: Resolve<PostCSSConfig> = async (options, config) => { | ||
| for (const plugin of await resolveConfig(options, config)) { | ||
| // Because postcss is not included in peerDependencies of tailwindcss | ||
| if (plugin === 'tailwindcss') return ['postcss']; |
There was a problem hiding this comment.
What's the reason for not adding a check for tailwindcss in config.plugins to the resolveConfig function directly?
There was a problem hiding this comment.
I misunderstood the implementation policy🙏
FIxed!
03a7583
There was a problem hiding this comment.
Sorry, there was a mistake.
There was a problem hiding this comment.
Sorry taro. Is there anything in the documentation or code that could have prevented this? Maybe we can improve it for the next contributor.
Thanks for the fix!
There was a problem hiding this comment.
Sorry, there was a mistake.
Re-fixed!
Sorry taro. Is there anything in the documentation or code that could have prevented this? Maybe we can improve it for the next contributor.
I re-read the documentation again, and it succinctly describes how to use resolveConfig, so I thought it was fine as it is.
My misunderstanding was due to overcomplicating the issue, as it was a slightly exceptional modification, such as adding the plugin's dependency itself (postcss).
taro-28
force-pushed
the
add-resolve-to-postcss-plugin
branch
from
7d649cc
to
03a7583
Compare
taro-28
force-pushed
the
add-resolve-to-postcss-plugin
branch
from
03a7583
to
d56b911
Compare
Co-authored-by: Lars Kappert <[email protected]>
taro-28
force-pushed
the
add-resolve-to-postcss-plugin
branch
from
a889af7
to
4db3279
Compare
|
Thank you! 🙏 |
|
🚀 This pull request is included in v5.27.3. See Release 5.27.3 for release notes. Using Knip in a commercial project? Please consider becoming a sponsor. |
Closes #762