Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--static now also copies background images #461

Merged
merged 1 commit into from
Nov 5, 2023

Conversation

MartenBE
Copy link
Contributor

@MartenBE MartenBE commented Sep 28, 2023

This should fix comment #389 (comment) .

@webpro
Copy link
Owner

webpro commented Oct 24, 2023

Thanks @MartenBE! Any chance you could add a test for this?

@MartenBE
Copy link
Contributor Author

Thanks @MartenBE! Any chance you could add a test for this?

I looked, but there are no tests in the code for static.js, so I wasn't sure how to best tackle this. Any pointers?

@webpro
Copy link
Owner

webpro commented Nov 5, 2023

Ah was too quick with my question for a test, sorry. Let's get stuff merged and maybe add some after the dust settles.

@webpro webpro merged commit 393f1f4 into webpro:main Nov 5, 2023
1 check failed
@MartenBE MartenBE deleted the also-copy-background-img branch December 4, 2023 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants