switch to async streaming download: #1982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
When the multi-WACZs being produced in this branch are loaded into ReplayWeb.page, no seed pages or resources are listed. There may be something slightly off, investigating further. |
- remove unused sync functions - use async methods from stream-zip - note that stream-zip still does a sync->async conversion under the hood - follow-up to #1933 for streaming download improvements
fully remove boto tests: update test to ensure multi-wacz resources name == path
ikreymer
force-pushed
the
async-streaming-download
branch
from
630255c
to
6036319
Compare
only include name, path, hash, bytes in each resource entry!
|
Should be fixed now! Turns out the datapackage.json was not quite valid, had incorrect |
tw4l
approved these changes
Oct 3, 2024
|
Tested on dev and working well! Nice job |
…age v1: - include 'id', but also 'title', 'description' and 'organization' fields, as well as 'crawlId' when possible - add 'type' indicating 'crawl', 'upload', 'collection', 'qa-run'
tw4l
reviewed
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
name,path,hash,bytesto match single WACZ.type(crawl,upload,collection,qaRun),id(unique id for the object),title/descriptionif available (for crawl/upload/collection), andcrawlIdforqaRun