Subscription Update Quotas #1988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ikreymer
commented
Aug 1, 2024
•
ikreymer
commented
- Follow-up to Adds Subscription API #1914, allows SubscriptionUpdate event to also update quotas.
- Passes current usage info + current billing page URL to portalUrl request for external app to be able to respond with best portalUrl
- get_origin() moved to utils to be available more generally.
- Updates billing tab to show current plans, switches order of quotas to list execution time, storage first
- supports updating quotas in SubscriptionUpdate event - sends current storage (bytesStored) and usage (monthlyExecMinutes) in portal URL request
move get_origin() to utils for more general use
ikreymer
commented
Aug 2, 2024
| @@ -195,6 +196,22 @@ export class OrgSettingsBilling extends TailwindElement { | |||
| `; | |||
| } | |||
|
|
|||
| private getPlanName(planId: string) { | |||
There was a problem hiding this comment.
Is this worth doing for localization, or just use capitalize() for now for maximum flexibility?
There was a problem hiding this comment.
I think this is worth doing, nice to have the hook when/if we implement localization later.
tw4l
reviewed
Aug 5, 2024
tw4l
approved these changes
Aug 5, 2024
|
Tests updated to include quota change in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.