Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding secret into ingress template #2085

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

gitreich
Copy link

For manually adding a secret for a tls of another authority then Let's Encrypt
See #2077
Fix for frontend&backend ingress
Still open: auth-signer is not using the same secret

@ikreymer
Copy link
Member

ikreymer commented Oct 3, 2024

Thanks for starting this! I was thinking we'd want to actually have the secret be created as part of the Helm chart, from the key and cert files themselves, eg something like:

...
tls: true
tlsCert: <path/to/cert>
tlsKey: <path/to/key>

and then adding a Secret definition in secrets.yaml that creates the secret from these files. But, I think that does mean the cert and key files need to be in the same directory as the chart, which may be less than ideal...

I guess providing a separate Secret might be easy enough, given that the user is responsible for managing it.

For authsign, I think it'll need to be updated, since it doesn't really support working with external certs or k8s secrets at the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants