Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Public org profile page #2172

Merged

Conversation

SuaYoo
Copy link
Member

@SuaYoo SuaYoo commented Nov 21, 2024

Resolves #2156
Resolves #2133
Follows #2174 (must be deployed to dev for manual testing steps)

Changes

  • Enables creating a public org profile page with description and website at /profile/<org slug>
  • Updates current "Overview" page to be "Dashboard", found under /dashboard
  • Organizes org "General" settings tab by "General", "Profile", and "Developer Tools"
  • Adds sign up banner to log in page for consistent CTA banners
  • Updates copy and docs to support changes

Manual testing

  1. Log in as crawler
  2. Go to org "Settings"
  3. Update profile description and website. Verify values save as expected
  4. Click "Preview public profile page". Verify banner is shown with text describing that profile is still private
  5. Log out
  6. Go to /profile/<your org slug>. Verify generic "not found" message is shown
  7. Log back in
  8. Go back to org settings
  9. Enable "Allow anyone to see org"
  10. Go back to public profile page and refresh. Verify preview banner is no longer shown, while controls to edit the page are still visible
  11. Log out
  12. Go to /profile/<your org slug>. Verify page is still visible

Screenshots

Org Settings

Screenshot 2024-11-26 at 2 35 23 PM Screenshot 2024-11-26 at 2 35 46 PM Screenshot 2024-11-26 at 2 35 52 PM

Org Profile (private preview)

Screenshot 2024-11-26 at 2 57 36 PM

Org Profile (public)

Screenshot 2024-11-26 at 2 57 54 PM

Sign In

Screenshot 2024-11-26 at 2 56 43 PM

Generic 404

Screenshot 2024-11-26 at 2 56 54 PM

Docs: User Guide > Org Settings > Change Org Settings

Screenshot 2024-11-26 at 3 29 39 PM

Follow-ups

This change doesn't include actual public collections yet, which will be addressed with #2182

Base automatically changed from issue-2158-public-org-backend to public-collections-feature November 22, 2024 16:47
@SuaYoo SuaYoo force-pushed the issue-2158-public-org-backend--frontend branch from 967da1a to 1a583d3 Compare November 25, 2024 17:42
@SuaYoo SuaYoo changed the title wip: Public org collections page feat: Public org profile page Nov 26, 2024
@SuaYoo SuaYoo marked this pull request as ready for review November 26, 2024 22:59
@tw4l tw4l force-pushed the issue-2158-public-org-backend--frontend branch from 974f1a7 to cc40157 Compare November 27, 2024 15:35
@tw4l
Copy link
Member

tw4l commented Nov 27, 2024

Merged public collections API branch into feature branch and rebased this on that so it's now possible to run backend + frontend locally off this branch.

@SuaYoo SuaYoo force-pushed the public-collections-feature branch from fb63602 to fcaf2a2 Compare November 27, 2024 16:18
@SuaYoo SuaYoo force-pushed the issue-2158-public-org-backend--frontend branch from cc40157 to 362ce47 Compare November 27, 2024 17:06
@tw4l tw4l force-pushed the public-collections-feature branch from fcaf2a2 to 74c1026 Compare November 27, 2024 17:39
Copy link
Member

@Shrinks99 Shrinks99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A great start to the future of public content on Browsertrix!!

@SuaYoo SuaYoo marked this pull request as draft November 27, 2024 22:49
@SuaYoo SuaYoo force-pushed the public-collections-feature branch from 74c1026 to 25ad642 Compare November 28, 2024 01:11
@SuaYoo SuaYoo force-pushed the issue-2158-public-org-backend--frontend branch 2 times, most recently from c59c079 to 12523d3 Compare November 28, 2024 01:19
@SuaYoo SuaYoo marked this pull request as ready for review November 28, 2024 03:06
@SuaYoo SuaYoo requested a review from Shrinks99 November 28, 2024 03:06

export enum RouteNamespace {
PrivateOrgs = "orgs",
PublicOrgs = "profile",
Copy link
Member Author

@SuaYoo SuaYoo Nov 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can easily be changed if someone has a pithy and creative idea for a public namespace. I want us to consider something other than public since that's helpful to us internally by being quite literal, but to anyone who's able to view the pages it'll be redundant, since they can see the page.

@emma-sg emma-sg mentioned this pull request Dec 2, 2024
Copy link
Member

@emma-sg emma-sg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple thoughts, but this looks great otherwise!

emma-sg added a commit that referenced this pull request Dec 3, 2024
Adds a simple verified badge to public pages (off by default currently
until there's a corresponding backend change).

To be merged after #2172 (& once corresponding backend changes are
done).

<img width="1057" alt="Screenshot_2024-12-02_at_3 12 57_PM"
src="https://github.com/user-attachments/assets/4a70b7c8-9c88-42c3-ae78-59a12228f277">
<img width="318" alt="Screenshot_2024-12-02_at_3 13 54_PM"
src="https://github.com/user-attachments/assets/15985c2e-9ac7-4d65-a668-578807487766">

---------

Co-authored-by: emma-sg <[email protected]>
@SuaYoo SuaYoo marked this pull request as draft December 3, 2024 20:47
@SuaYoo SuaYoo merged commit f7a83b1 into public-collections-feature Dec 4, 2024
4 checks passed
@SuaYoo SuaYoo deleted the issue-2158-public-org-backend--frontend branch December 4, 2024 03:04
@SuaYoo SuaYoo restored the issue-2158-public-org-backend--frontend branch December 4, 2024 03:26
@SuaYoo SuaYoo deleted the issue-2158-public-org-backend--frontend branch December 4, 2024 03:46
SuaYoo added a commit that referenced this pull request Dec 9, 2024
- Enables creating a public org profile page with description and
website at `/profile/<org slug>`
- Updates current "Overview" page to be "Dashboard", found under
`/dashboard`
- Organizes org "General" settings tab by "General", "Profile", and
"Developer Tools"
- Adds sign up banner to log in page for consistent CTA banners
- Updates copy and docs to support changes
- Allows user to set collection to private, public, or unlisted
- Adds route for public collection page with basic page layout
- Refactors copy button to abstract clipboard functionality
---------

Co-authored-by: Henry Wilkinson <[email protected]>
Co-authored-by: emma <[email protected]>
SuaYoo added a commit that referenced this pull request Dec 9, 2024
- Enables creating a public org profile page with description and
website at `/profile/<org slug>`
- Updates current "Overview" page to be "Dashboard", found under
`/dashboard`
- Organizes org "General" settings tab by "General", "Profile", and
"Developer Tools"
- Adds sign up banner to log in page for consistent CTA banners
- Updates copy and docs to support changes
- Allows user to set collection to private, public, or unlisted
- Adds route for public collection page with basic page layout
- Refactors copy button to abstract clipboard functionality
---------

Co-authored-by: Henry Wilkinson <[email protected]>
Co-authored-by: emma <[email protected]>
SuaYoo added a commit that referenced this pull request Dec 10, 2024
- Enables creating a public org profile page with description and
website at `/profile/<org slug>`
- Updates current "Overview" page to be "Dashboard", found under
`/dashboard`
- Organizes org "General" settings tab by "General", "Profile", and
"Developer Tools"
- Adds sign up banner to log in page for consistent CTA banners
- Updates copy and docs to support changes
- Allows user to set collection to private, public, or unlisted
- Adds route for public collection page with basic page layout
- Refactors copy button to abstract clipboard functionality
---------

Co-authored-by: Henry Wilkinson <[email protected]>
Co-authored-by: emma <[email protected]>
SuaYoo added a commit that referenced this pull request Dec 10, 2024
- Enables creating a public org profile page with description and
website at `/profile/<org slug>`
- Updates current "Overview" page to be "Dashboard", found under
`/dashboard`
- Organizes org "General" settings tab by "General", "Profile", and
"Developer Tools"
- Adds sign up banner to log in page for consistent CTA banners
- Updates copy and docs to support changes
- Allows user to set collection to private, public, or unlisted
- Adds route for public collection page with basic page layout
- Refactors copy button to abstract clipboard functionality
---------

Co-authored-by: Henry Wilkinson <[email protected]>
Co-authored-by: emma <[email protected]>
SuaYoo added a commit that referenced this pull request Dec 10, 2024
- Enables creating a public org profile page with description and
website at `/profile/<org slug>`
- Updates current "Overview" page to be "Dashboard", found under
`/dashboard`
- Organizes org "General" settings tab by "General", "Profile", and
"Developer Tools"
- Adds sign up banner to log in page for consistent CTA banners
- Updates copy and docs to support changes
- Allows user to set collection to private, public, or unlisted
- Adds route for public collection page with basic page layout
- Refactors copy button to abstract clipboard functionality
---------

Co-authored-by: Henry Wilkinson <[email protected]>
Co-authored-by: emma <[email protected]>
SuaYoo added a commit that referenced this pull request Dec 10, 2024
- Enables creating a public org profile page with description and
website at `/profile/<org slug>`
- Updates current "Overview" page to be "Dashboard", found under
`/dashboard`
- Organizes org "General" settings tab by "General", "Profile", and
"Developer Tools"
- Adds sign up banner to log in page for consistent CTA banners
- Updates copy and docs to support changes
- Allows user to set collection to private, public, or unlisted
- Adds route for public collection page with basic page layout
- Refactors copy button to abstract clipboard functionality
---------

Co-authored-by: Henry Wilkinson <[email protected]>
Co-authored-by: emma <[email protected]>
SuaYoo added a commit that referenced this pull request Dec 11, 2024
- Enables creating a public org profile page with description and
website at `/profile/<org slug>`
- Updates current "Overview" page to be "Dashboard", found under
`/dashboard`
- Organizes org "General" settings tab by "General", "Profile", and
"Developer Tools"
- Adds sign up banner to log in page for consistent CTA banners
- Updates copy and docs to support changes
- Allows user to set collection to private, public, or unlisted
- Adds route for public collection page with basic page layout
- Refactors copy button to abstract clipboard functionality
---------

Co-authored-by: Henry Wilkinson <[email protected]>
Co-authored-by: emma <[email protected]>
SuaYoo added a commit that referenced this pull request Dec 11, 2024
- Enables creating a public org profile page with description and
website at `/profile/<org slug>`
- Updates current "Overview" page to be "Dashboard", found under
`/dashboard`
- Organizes org "General" settings tab by "General", "Profile", and
"Developer Tools"
- Adds sign up banner to log in page for consistent CTA banners
- Updates copy and docs to support changes
- Allows user to set collection to private, public, or unlisted
- Adds route for public collection page with basic page layout
- Refactors copy button to abstract clipboard functionality
---------

Co-authored-by: Henry Wilkinson <[email protected]>
Co-authored-by: emma <[email protected]>
SuaYoo added a commit that referenced this pull request Dec 11, 2024
- Enables creating a public org profile page with description and
website at `/profile/<org slug>`
- Updates current "Overview" page to be "Dashboard", found under
`/dashboard`
- Organizes org "General" settings tab by "General", "Profile", and
"Developer Tools"
- Adds sign up banner to log in page for consistent CTA banners
- Updates copy and docs to support changes
- Allows user to set collection to private, public, or unlisted
- Adds route for public collection page with basic page layout
- Refactors copy button to abstract clipboard functionality
---------

Co-authored-by: Henry Wilkinson <[email protected]>
Co-authored-by: emma <[email protected]>
SuaYoo added a commit that referenced this pull request Dec 11, 2024
- Enables creating a public org profile page with description and
website at `/profile/<org slug>`
- Updates current "Overview" page to be "Dashboard", found under
`/dashboard`
- Organizes org "General" settings tab by "General", "Profile", and
"Developer Tools"
- Adds sign up banner to log in page for consistent CTA banners
- Updates copy and docs to support changes
- Allows user to set collection to private, public, or unlisted
- Adds route for public collection page with basic page layout
- Refactors copy button to abstract clipboard functionality
---------

Co-authored-by: Henry Wilkinson <[email protected]>
Co-authored-by: emma <[email protected]>
SuaYoo added a commit that referenced this pull request Dec 16, 2024
- Enables creating a public org profile page with description and
website at `/profile/<org slug>`
- Updates current "Overview" page to be "Dashboard", found under
`/dashboard`
- Organizes org "General" settings tab by "General", "Profile", and
"Developer Tools"
- Adds sign up banner to log in page for consistent CTA banners
- Updates copy and docs to support changes
- Allows user to set collection to private, public, or unlisted
- Adds route for public collection page with basic page layout
- Refactors copy button to abstract clipboard functionality
---------

Co-authored-by: Henry Wilkinson <[email protected]>
Co-authored-by: emma <[email protected]>
SuaYoo added a commit that referenced this pull request Dec 16, 2024
- Enables creating a public org profile page with description and
website at `/profile/<org slug>`
- Updates current "Overview" page to be "Dashboard", found under
`/dashboard`
- Organizes org "General" settings tab by "General", "Profile", and
"Developer Tools"
- Adds sign up banner to log in page for consistent CTA banners
- Updates copy and docs to support changes
- Allows user to set collection to private, public, or unlisted
- Adds route for public collection page with basic page layout
- Refactors copy button to abstract clipboard functionality
---------

Co-authored-by: Henry Wilkinson <[email protected]>
Co-authored-by: emma <[email protected]>
SuaYoo added a commit that referenced this pull request Dec 16, 2024
- Enables creating a public org profile page with description and
website at `/profile/<org slug>`
- Updates current "Overview" page to be "Dashboard", found under
`/dashboard`
- Organizes org "General" settings tab by "General", "Profile", and
"Developer Tools"
- Adds sign up banner to log in page for consistent CTA banners
- Updates copy and docs to support changes
- Allows user to set collection to private, public, or unlisted
- Adds route for public collection page with basic page layout
- Refactors copy button to abstract clipboard functionality
---------

Co-authored-by: Henry Wilkinson <[email protected]>
Co-authored-by: emma <[email protected]>
SuaYoo added a commit that referenced this pull request Dec 16, 2024
- Enables creating a public org profile page with description and
website at `/profile/<org slug>`
- Updates current "Overview" page to be "Dashboard", found under
`/dashboard`
- Organizes org "General" settings tab by "General", "Profile", and
"Developer Tools"
- Adds sign up banner to log in page for consistent CTA banners
- Updates copy and docs to support changes
- Allows user to set collection to private, public, or unlisted
- Adds route for public collection page with basic page layout
- Refactors copy button to abstract clipboard functionality
---------

Co-authored-by: Henry Wilkinson <[email protected]>
Co-authored-by: emma <[email protected]>
SuaYoo added a commit that referenced this pull request Dec 16, 2024
- Enables creating a public org profile page with description and
website at `/profile/<org slug>`
- Updates current "Overview" page to be "Dashboard", found under
`/dashboard`
- Organizes org "General" settings tab by "General", "Profile", and
"Developer Tools"
- Adds sign up banner to log in page for consistent CTA banners
- Updates copy and docs to support changes
- Allows user to set collection to private, public, or unlisted
- Adds route for public collection page with basic page layout
- Refactors copy button to abstract clipboard functionality
---------

Co-authored-by: Henry Wilkinson <[email protected]>
Co-authored-by: emma <[email protected]>
SuaYoo added a commit that referenced this pull request Dec 17, 2024
- Enables creating a public org profile page with description and
website at `/profile/<org slug>`
- Updates current "Overview" page to be "Dashboard", found under
`/dashboard`
- Organizes org "General" settings tab by "General", "Profile", and
"Developer Tools"
- Adds sign up banner to log in page for consistent CTA banners
- Updates copy and docs to support changes
- Allows user to set collection to private, public, or unlisted
- Adds route for public collection page with basic page layout
- Refactors copy button to abstract clipboard functionality
---------

Co-authored-by: Henry Wilkinson <[email protected]>
Co-authored-by: emma <[email protected]>
SuaYoo added a commit that referenced this pull request Dec 23, 2024
- Enables creating a public org profile page with description and
website at `/profile/<org slug>`
- Updates current "Overview" page to be "Dashboard", found under
`/dashboard`
- Organizes org "General" settings tab by "General", "Profile", and
"Developer Tools"
- Adds sign up banner to log in page for consistent CTA banners
- Updates copy and docs to support changes
- Allows user to set collection to private, public, or unlisted
- Adds route for public collection page with basic page layout
- Refactors copy button to abstract clipboard functionality
---------

Co-authored-by: Henry Wilkinson <[email protected]>
Co-authored-by: emma <[email protected]>
SuaYoo added a commit that referenced this pull request Jan 6, 2025
- Enables creating a public org profile page with description and
website at `/profile/<org slug>`
- Updates current "Overview" page to be "Dashboard", found under
`/dashboard`
- Organizes org "General" settings tab by "General", "Profile", and
"Developer Tools"
- Adds sign up banner to log in page for consistent CTA banners
- Updates copy and docs to support changes
- Allows user to set collection to private, public, or unlisted
- Adds route for public collection page with basic page layout
- Refactors copy button to abstract clipboard functionality
---------

Co-authored-by: Henry Wilkinson <[email protected]>
Co-authored-by: emma <[email protected]>
SuaYoo added a commit that referenced this pull request Jan 7, 2025
- Enables creating a public org profile page with description and
website at `/profile/<org slug>`
- Updates current "Overview" page to be "Dashboard", found under
`/dashboard`
- Organizes org "General" settings tab by "General", "Profile", and
"Developer Tools"
- Adds sign up banner to log in page for consistent CTA banners
- Updates copy and docs to support changes
- Allows user to set collection to private, public, or unlisted
- Adds route for public collection page with basic page layout
- Refactors copy button to abstract clipboard functionality
---------

Co-authored-by: Henry Wilkinson <[email protected]>
Co-authored-by: emma <[email protected]>
SuaYoo added a commit that referenced this pull request Jan 7, 2025
- Enables creating a public org profile page with description and
website at `/profile/<org slug>`
- Updates current "Overview" page to be "Dashboard", found under
`/dashboard`
- Organizes org "General" settings tab by "General", "Profile", and
"Developer Tools"
- Adds sign up banner to log in page for consistent CTA banners
- Updates copy and docs to support changes
- Allows user to set collection to private, public, or unlisted
- Adds route for public collection page with basic page layout
- Refactors copy button to abstract clipboard functionality
---------

Co-authored-by: Henry Wilkinson <[email protected]>
Co-authored-by: emma <[email protected]>
SuaYoo added a commit that referenced this pull request Jan 9, 2025
- Enables creating a public org profile page with description and
website at `/profile/<org slug>`
- Updates current "Overview" page to be "Dashboard", found under
`/dashboard`
- Organizes org "General" settings tab by "General", "Profile", and
"Developer Tools"
- Adds sign up banner to log in page for consistent CTA banners
- Updates copy and docs to support changes
- Allows user to set collection to private, public, or unlisted
- Adds route for public collection page with basic page layout
- Refactors copy button to abstract clipboard functionality
---------

Co-authored-by: Henry Wilkinson <[email protected]>
Co-authored-by: emma <[email protected]>
SuaYoo added a commit that referenced this pull request Jan 13, 2025
- Enables creating a public org profile page with description and
website at `/profile/<org slug>`
- Updates current "Overview" page to be "Dashboard", found under
`/dashboard`
- Organizes org "General" settings tab by "General", "Profile", and
"Developer Tools"
- Adds sign up banner to log in page for consistent CTA banners
- Updates copy and docs to support changes
- Allows user to set collection to private, public, or unlisted
- Adds route for public collection page with basic page layout
- Refactors copy button to abstract clipboard functionality
---------

Co-authored-by: Henry Wilkinson <[email protected]>
Co-authored-by: emma <[email protected]>
SuaYoo added a commit that referenced this pull request Jan 13, 2025
- Enables creating a public org profile page with description and
website at `/profile/<org slug>`
- Updates current "Overview" page to be "Dashboard", found under
`/dashboard`
- Organizes org "General" settings tab by "General", "Profile", and
"Developer Tools"
- Adds sign up banner to log in page for consistent CTA banners
- Updates copy and docs to support changes
- Allows user to set collection to private, public, or unlisted
- Adds route for public collection page with basic page layout
- Refactors copy button to abstract clipboard functionality
---------

Co-authored-by: Henry Wilkinson <[email protected]>
Co-authored-by: emma <[email protected]>
ikreymer added a commit that referenced this pull request Jan 14, 2025
feat: Public collections, includes:
- feat: Public org profile page #2172
- feat: Collection thumbnails, start page, and public view updates #2209
- feat: Track collection events #2256
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Public org home page [Feature] Add sign-up/info page link to log in page
4 participants