Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

requirements: Adjust installation of PyAMF module. #920

Merged
merged 3 commits into from
Nov 7, 2024

Conversation

Hellseher
Copy link
Contributor

@Hellseher Hellseher commented Nov 6, 2024

  • requirements.txt (Py3AMF, pyAMF): Add extra requirements from setup.py to here with conditions.
  • setup.py (load_requirements): Remove conditions to install Py3AMF, pyAMF.

Description

Covering #919

Motivation and Context

To resolve installation issues while using requirements.txt with pip.

Screenshots (if appropriate):

Types of changes

  • Replay fix (fixes a replay specific issue)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added or updated tests to cover my changes.
  • All new and existing tests passed.
  • Refactoring with no breaking changes

* requirements.txt (Py3AMF, pyAMF): Move extra requirements from setup.py
to here with conditions.
* setup.py (load_requirements): Remove condition to install Py3AMF, pyAMF.
requirements.txt Outdated Show resolved Hide resolved
@tw4l tw4l merged commit b44c93b into webrecorder:main Nov 7, 2024
0 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants