Skip to content

Commit

Permalink
dont modify RTCSessionDescription.sdp
Browse files Browse the repository at this point in the history
  • Loading branch information
fippo committed Mar 24, 2024
1 parent da82635 commit d5955c3
Showing 1 changed file with 7 additions and 6 deletions.
13 changes: 7 additions & 6 deletions test/e2e/maxMessageSize.js
Original file line number Diff line number Diff line change
Expand Up @@ -42,12 +42,13 @@ describe('maxMessageSize', () => {

function patchMaxMessageSizeFactory(maxMessageSize) {
return ((description) => {
description.sdp = description.sdp.replace(
/^a=max-message-size:\s*(\d+)\s*$/gm, '');
description.sdp = description.sdp.replace(
/(^m=application\s+\d+\s+[\w/]*SCTP.*$)/m,
'$1\r\na=max-message-size:' + maxMessageSize);
return description;
return {
type: description.type,
sdp: description.sdp
.replace(/^a=max-message-size:\s*(\d+)\s*$/gm, '')

Check failure on line 48 in test/e2e/maxMessageSize.js

View workflow job for this annotation

GitHub Actions / test

Expected indentation of 10 spaces but found 12

Check failure on line 48 in test/e2e/maxMessageSize.js

View workflow job for this annotation

GitHub Actions / test (chrome, stable)

Expected indentation of 10 spaces but found 12

Check failure on line 48 in test/e2e/maxMessageSize.js

View workflow job for this annotation

GitHub Actions / test (chrome, beta)

Expected indentation of 10 spaces but found 12

Check failure on line 48 in test/e2e/maxMessageSize.js

View workflow job for this annotation

GitHub Actions / test (chrome, dev)

Expected indentation of 10 spaces but found 12

Check failure on line 48 in test/e2e/maxMessageSize.js

View workflow job for this annotation

GitHub Actions / test (firefox, nightly)

Expected indentation of 10 spaces but found 12
.replace(/(^m=application\s+\d+\s+[\w/]*SCTP.*$)/m,

Check failure on line 49 in test/e2e/maxMessageSize.js

View workflow job for this annotation

GitHub Actions / test

Expected indentation of 10 spaces but found 12

Check failure on line 49 in test/e2e/maxMessageSize.js

View workflow job for this annotation

GitHub Actions / test (chrome, stable)

Expected indentation of 10 spaces but found 12

Check failure on line 49 in test/e2e/maxMessageSize.js

View workflow job for this annotation

GitHub Actions / test (chrome, beta)

Expected indentation of 10 spaces but found 12

Check failure on line 49 in test/e2e/maxMessageSize.js

View workflow job for this annotation

GitHub Actions / test (chrome, dev)

Expected indentation of 10 spaces but found 12

Check failure on line 49 in test/e2e/maxMessageSize.js

View workflow job for this annotation

GitHub Actions / test (firefox, nightly)

Expected indentation of 10 spaces but found 12
'$1\r\na=max-message-size:' + maxMessageSize),

Check failure on line 50 in test/e2e/maxMessageSize.js

View workflow job for this annotation

GitHub Actions / test

Expected indentation of 12 spaces but found 21

Check failure on line 50 in test/e2e/maxMessageSize.js

View workflow job for this annotation

GitHub Actions / test (chrome, stable)

Expected indentation of 12 spaces but found 21

Check failure on line 50 in test/e2e/maxMessageSize.js

View workflow job for this annotation

GitHub Actions / test (chrome, beta)

Expected indentation of 12 spaces but found 21

Check failure on line 50 in test/e2e/maxMessageSize.js

View workflow job for this annotation

GitHub Actions / test (chrome, dev)

Expected indentation of 12 spaces but found 21

Check failure on line 50 in test/e2e/maxMessageSize.js

View workflow job for this annotation

GitHub Actions / test (firefox, nightly)

Expected indentation of 12 spaces but found 21
}

Check failure on line 51 in test/e2e/maxMessageSize.js

View workflow job for this annotation

GitHub Actions / test

Missing semicolon

Check failure on line 51 in test/e2e/maxMessageSize.js

View workflow job for this annotation

GitHub Actions / test (chrome, stable)

Missing semicolon

Check failure on line 51 in test/e2e/maxMessageSize.js

View workflow job for this annotation

GitHub Actions / test (chrome, beta)

Missing semicolon

Check failure on line 51 in test/e2e/maxMessageSize.js

View workflow job for this annotation

GitHub Actions / test (chrome, dev)

Missing semicolon

Check failure on line 51 in test/e2e/maxMessageSize.js

View workflow job for this annotation

GitHub Actions / test (firefox, nightly)

Missing semicolon
});
}

Expand Down

0 comments on commit d5955c3

Please sign in to comment.