Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: drop legacy CLI templates #4867

Merged
merged 3 commits into from
Feb 16, 2025
Merged

feat: drop legacy CLI templates #4867

merged 3 commits into from
Feb 16, 2025

Conversation

TrySound
Copy link
Member

Here dropped vanilla and legacy vercel templates.
Replaced vanilla with docker in publish dialog.

Screenshot 2025-02-13 at 18 34 53

Here dropped vanilla and legacy vercel templates.
Replaced vanilla with docker in publish dialog.
@kof
Copy link
Member

kof commented Feb 13, 2025

Why do we call it Vanilla instead of Docker?

@TrySound
Copy link
Member Author

Because we have ssg completely unrelated to docker on the same option.

@kof
Copy link
Member

kof commented Feb 13, 2025

Can you show the options we have now? I haven't checked
I think I misunderstand ...

@TrySound
Copy link
Member Author

The choice works for both ssg and ssr. Above ssg download, below it ssr instructions.

image

@kof
Copy link
Member

kof commented Feb 13, 2025

Oh I see so we say vanilla but if you want a remix app you use docker, but if you want static hmtl/css you click download. So we kinda lost the option of building the js app without docker and without spcific configs for vercel/netlify

@TrySound
Copy link
Member Author

Maybe split vanilla into static and docker and show only one part of dialog for each. For vercel and netlify show both parts.

@kof
Copy link
Member

kof commented Feb 13, 2025

Or keep Vanilla but show 2 code options in step 3: with docker and without docker

@TrySound
Copy link
Member Author

Vanilla server doesn't make much sense and I don't want to support it as additional template

@kof
Copy link
Member

kof commented Feb 13, 2025

Vanilla server doesn't make much sense and I don't want to support it as additional template

Ok, but how can someone create a project with remix and without a docker?

@TrySound
Copy link
Member Author

and do what with it?

@TrySound
Copy link
Member Author

image image

@kof
Copy link
Member

kof commented Feb 13, 2025

and do what with it?

Its not up to us, they may want to start the node environment anywhere, without using docker. Who knows, this is the default in any case

@kof
Copy link
Member

kof commented Feb 13, 2025

image image

this looks good, still don't understand how are we communicating regular app checkout

@TrySound
Copy link
Member Author

Its not up to us, they may want to start the node environment anywhere, without using docker. Who knows, this is the default in any case

they can just use docker template, it is the same but with dockerfile inside

@kof
Copy link
Member

kof commented Feb 13, 2025

they can just use docker template, it is the same but with dockerfile inside

Where is this communicated?

What are the CLI commands to use without docker? lets say I don't have and don't want to install docker.

@kof
Copy link
Member

kof commented Feb 13, 2025

Why can't we provide the cli commands to create the app without docker?

@TrySound
Copy link
Member Author

What are the CLI commands to use without docker? lets say I don't have and don't want to install docker.

$ webstudio

@kof
Copy link
Member

kof commented Feb 13, 2025

I think this needs to be exposed in that export UI, so that there are all logical options presented

@TrySound
Copy link
Member Author

Vanilla is a bad option. Users don't understand what it is. And it does not give any real value. We don't want to support bad react-router configuration by users.

Copy link
Member

@kof kof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • discussed adding some way of knowing there is a way for a local dev without docker

@johnsicili
Copy link
Contributor

Didn't review. Don't have much to add here besides I agree that it should be known that "Docker" is really just vanilla with a Dockerfile so someone can host on some other serverless platform besides the two we provide options for.

@TrySound TrySound merged commit 5c1c557 into main Feb 16, 2025
17 checks passed
@TrySound TrySound deleted the legacy-templates branch February 16, 2025 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants