-
Notifications
You must be signed in to change notification settings - Fork 856
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: drop legacy CLI templates #4867
Conversation
Here dropped vanilla and legacy vercel templates. Replaced vanilla with docker in publish dialog.
Why do we call it Vanilla instead of Docker? |
Because we have ssg completely unrelated to docker on the same option. |
Can you show the options we have now? I haven't checked |
Oh I see so we say vanilla but if you want a remix app you use docker, but if you want static hmtl/css you click download. So we kinda lost the option of building the js app without docker and without spcific configs for vercel/netlify |
Maybe split vanilla into static and docker and show only one part of dialog for each. For vercel and netlify show both parts. |
Or keep Vanilla but show 2 code options in step 3: with docker and without docker |
Vanilla server doesn't make much sense and I don't want to support it as additional template |
Ok, but how can someone create a project with remix and without a docker? |
and do what with it? |
Its not up to us, they may want to start the node environment anywhere, without using docker. Who knows, this is the default in any case |
they can just use docker template, it is the same but with dockerfile inside |
Where is this communicated? What are the CLI commands to use without docker? lets say I don't have and don't want to install docker. |
Why can't we provide the cli commands to create the app without docker? |
|
I think this needs to be exposed in that export UI, so that there are all logical options presented |
Vanilla is a bad option. Users don't understand what it is. And it does not give any real value. We don't want to support bad react-router configuration by users. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- discussed adding some way of knowing there is a way for a local dev without docker
Didn't review. Don't have much to add here besides I agree that it should be known that "Docker" is really just vanilla with a Dockerfile so someone can host on some other serverless platform besides the two we provide options for. |
Here dropped vanilla and legacy vercel templates.
Replaced vanilla with docker in publish dialog.