Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Context menu for advanced style panel #4876

Merged
merged 14 commits into from
Feb 15, 2025
Merged

feat: Context menu for advanced style panel #4876

merged 14 commits into from
Feb 15, 2025

Conversation

kof
Copy link
Member

@kof kof commented Feb 14, 2025

#4816

Description

  1. right click in advanced
  2. copy all
  3. copy one
  4. paste
  5. search now works for properties AND values
  6. backspace in add styles input when its empty now also closes the input same as esc

Steps for reproduction

  1. click button
  2. expect xyz

Code Review

  • hi @kof, I need you to do
    • conceptual review (architecture, feature-correctness)
    • detailed review (read every line)
    • test it on preview

Before requesting a review

  • made a self-review
  • added inline comments where things may be not obvious (the "why", not "what")

Before merging

  • tested locally and on preview environment (preview dev login: 0000)
  • updated test cases document
  • added tests
  • if any new env variables are added, added them to .env file

@kof kof marked this pull request as ready for review February 15, 2025 00:11
@kof kof requested review from TrySound and johnsicili February 15, 2025 00:11
@kof
Copy link
Member Author

kof commented Feb 15, 2025

@johnsicili needed to merge, please test when you get time on main

@kof kof merged commit 769b246 into main Feb 15, 2025
19 checks passed
@kof kof deleted the context-menu branch February 15, 2025 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants