Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

experimental: more advanced style panel features #4890

Merged
merged 14 commits into from
Feb 19, 2025
Merged

experimental: more advanced style panel features #4890

merged 14 commits into from
Feb 19, 2025

Conversation

kof
Copy link
Member

@kof kof commented Feb 18, 2025

Ref #4816
Closes #4874

Description

  • Memorizing recent properties by instance, so that when user switches between instances and comes back they are still in-place
  • alt+shift+a for advanced mode shorthand

Steps for reproduction

  1. click button
  2. expect xyz

Code Review

  • hi @kof, I need you to do
    • conceptual review (architecture, feature-correctness)
    • detailed review (read every line)
    • test it on preview

Before requesting a review

  • made a self-review
  • added inline comments where things may be not obvious (the "why", not "what")

Before merging

  • tested locally and on preview environment (preview dev login: 0000)
  • updated test cases document
  • added tests
  • if any new env variables are added, added them to .env file

@kof kof changed the title experimental: Shorthands experimental: more advanced style panel feaures Feb 19, 2025
@kof kof marked this pull request as ready for review February 19, 2025 18:16
@kof kof requested review from TrySound and johnsicili February 19, 2025 18:16
Copy link
Contributor

@johnsicili johnsicili left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good except glitches we Dmd about when switching instances and style add field shows up really quickly

@kof kof changed the title experimental: more advanced style panel feaures experimental: more advanced style panel features Feb 19, 2025
@kof kof merged commit 2593087 into main Feb 19, 2025
17 checks passed
@kof kof deleted the shorthands branch February 19, 2025 20:26
@kof kof restored the shorthands branch February 20, 2025 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Main: Not all advanced properties show
3 participants