Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compact view for torrent list #1520

Open
wants to merge 17 commits into
base: master
Choose a base branch
from
Open

Compact view for torrent list #1520

wants to merge 17 commits into from

Conversation

fknop
Copy link

@fknop fknop commented Dec 10, 2018

Hi,

I implemented this small feature for a compacted list of torrents (reduce ~by half the space needed for one item in the list) via a button icon in the header.

I know this might not be a feature necessary to the core application so I'm adding this here and leaving it to discussion!

Tests / formatting may fail for now, I did not check those yet.

@fknop fknop changed the title WIP: compact view for torrent list Compact view for torrent list Jan 21, 2019
@dsernst
Copy link
Contributor

dsernst commented Apr 10, 2019

Can you post before & after screenshots?

@stale
Copy link

stale bot commented Jul 9, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale label Jul 9, 2019
@feross
Copy link
Member

feross commented Jul 10, 2019

Ping – can someone post screenshots of this?

In general, I'm against adding options for stuff like this. If the compact view is "better" then we should just change to using the compact view for everyone. In general, I agree that WebTorrent current takes up a bit too much space for each torrent list item, so this is probably a good PR to merge, minus the configuration button.

@stale stale bot removed the stale label Jul 10, 2019
@alxhotel
Copy link
Member

Before and after:

wt_compare_compact

@feross
Copy link
Member

feross commented Jul 10, 2019

@alxhotel Thanks for posting that. I like the general idea.

Issues:

  • The buttons on the right side or not properly vertically centered.
  • Does the torrent meta-info show up in two lines when the torrent is expanded? Would be more readable than keeping it on one line, in that situation.

@fknop
Copy link
Author

fknop commented Jul 11, 2019

I've managed to fix the vertical alignment locally, I think it should be well aligned now.

image

Right now the metadata is kept on one line when the torrent is expanded. I can try to fix this.

@fknop
Copy link
Author

fknop commented Jul 11, 2019

The behaviour is now the same as before when the torrent is expanded.

@feross
Copy link
Member

feross commented Jul 11, 2019

@fknop Thanks for making those changes. It appears that there is a merge conflict. Can you try to resolve that?

@fknop
Copy link
Author

fknop commented Jul 11, 2019

It should be working now. The app still has the two options, if you want to keep only one view I can probably remove the old one as well.
Or maybe adding a preference would be better than having a button on the main view?

@github-actions
Copy link

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

@github-actions github-actions bot added the stale label Jul 24, 2021
@alxhotel alxhotel removed the stale label Jul 24, 2021
@github-actions
Copy link

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

@github-actions github-actions bot added the stale label Sep 23, 2021
@github-actions github-actions bot closed this Oct 1, 2021
@alxhotel alxhotel reopened this Oct 1, 2021
@alxhotel alxhotel removed the stale label Oct 1, 2021
@DiegoRBaquero DiegoRBaquero self-assigned this Oct 19, 2021
@github-actions
Copy link

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

@github-actions github-actions bot added the stale label Dec 18, 2021
@github-actions github-actions bot closed this Dec 26, 2021
@alxhotel alxhotel reopened this Dec 26, 2021
@github-actions github-actions bot closed this Jan 3, 2022
@alxhotel alxhotel reopened this Jan 3, 2022
@alxhotel alxhotel added accepted and removed stale labels Jan 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants