Feature/linters

.eslintrc.js

@@ -1,33 +1,44 @@
-
 const fs = require('fs');
 const path = require('path');
 
-const prettierOptions = JSON.parse(
-  fs.readFileSync(path.resolve(__dirname, '.prettierrc'), 'utf8'),
-);
-
 // const app = JSON.parse(path.resolve(__dirname, 'app'));
 
 module.exports = {
   root: true,
   parser: 'babel-eslint',
-  extends: ['airbnb', 'prettier', 'prettier/react'],
-  plugins: ['prettier', 'redux-saga', 'react-native', 'react', 'react-hooks', 'jsx-a11y'],
+  extends: [
+    'airbnb',
+    'plugin:prettier/recommended',
+    'plugin:sonarjs/recommended',
+    'plugin:security/recommended-legacy',
+    'plugin:fp/recommended'
+  ],
+  plugins: [
+    'github',
+    'immutable',
+    'sonarjs',
+    'prettier',
+    'redux-saga',
+    'react-native',
+    'react',
+    'react-hooks',
+    'jsx-a11y',
+    'fp'
+  ],
   env: {
     jest: true,
     browser: true,
     node: true,
-    es6: true,
+    es6: true
   },
   parserOptions: {
     ecmaVersion: 6,
     sourceType: 'module',
     ecmaFeatures: {
-      jsx: true,
-    },
+      jsx: true
+    }
   },
   rules: {
-    'prettier/prettier': ['error', prettierOptions],
     'arrow-body-style': [2, 'as-needed'],
     'class-methods-use-this': 0,
     'import/imports-first': 0,
@@ -38,13 +49,6 @@ module.exports = {
     'import/no-unresolved': 0,
     'import/prefer-default-export': 0,
     'react/jsx-props-no-spreading': 0,
-    indent: [
-      2,
-      2,
-      {
-        SwitchCase: 1,
-      },
-    ],
     'jsx-a11y/aria-props': 2,
     'jsx-a11y/heading-has-content': 0,
     'jsx-a11y/label-has-associated-control': [
@@ -53,8 +57,8 @@ module.exports = {
         // NOTE: If this error triggers, either disable it or add
         // your custom components, labels and attributes via these options
         // See https://github.com/evcohen/eslint-plugin-jsx-a11y/blob/master/docs/rules/label-has-associated-control.md
-        controlComponents: ['Input'],
-      },
+        controlComponents: ['Input']
+      }
     ],
     'jsx-a11y/label-has-for': 0,
     'jsx-a11y/mouse-events-have-key-events': 2,
@@ -82,29 +86,76 @@ module.exports = {
     'redux-saga/no-yield-in-race': 2,
     'redux-saga/yield-effects': 2,
     'require-yield': 0,
-    'react/no-array-index-key': 0
+    'react/no-array-index-key': 0,
+    'react/jsx-curly-newline': 0,
+    'react/jsx-one-expression-per-line': 0,
+    'react/jsx-wrap-multilines': 0,
+    'react/no-unused-prop-types': 0,
+    'max-lines-per-function': ['error', 250],
+    'no-else-return': 'error',
+    'max-params': ['error', 3],
+    'require-jsdoc': [
+      'error',
+      {
+        require: {
+          FunctionDeclaration: true,
+          MethodDefinition: false,
+          ClassDeclaration: false,
+          ArrowFunctionExpression: false,
+          FunctionExpression: false
+        }
+      }
+    ],
+    'no-shadow': 'error',
+    complexity: ['error', 2],
+    'no-empty': 'error',
+    'import/order': [
+      'error',
+      {
+        groups: [
+          ['builtin', 'external', 'internal', 'parent', 'sibling', 'index']
+        ]
+      }
+    ],
+    'immutable/no-let': 2,
+    'immutable/no-this': 2,
+    'max-lines': ['error', 350],
+    'react-native/no-unused-styles': 2,
+    'react-native/split-platform-components': 2,
+    'react-native/no-inline-styles': 2,
+    'react-native/no-color-literals': 2,
+    'react-native/no-raw-text': 2,
+    'react-native/no-single-element-style-arrays': 2,
+    'fp/no-mutation': [
+      'error',
+      {
+        exceptions: [{ property: 'propTypes' }, { property: 'defaultProps' }]
+      }
+    ],
+    'fp/no-nil': 0,
+    'fp/no-unused-expression': 0
   },
-  "settings": {
-    "import/resolver": {
-      "node": {
-        "app": "./app",
-        "context": "app",
-        "resolve": {
-          "alias": {
-            "@assets": "./app/assets",
-            "@components": "./app/components",
-            "@containers": "./app/containers",
-            "@config": "./app/config",
-            "@navigators": "./app/navigators",
-            "@services": "./app/services",
-            "@themes": "./app/themes",
-            "@utils": "./app/utils"
+  settings: {
+    'import/resolver': {
+      node: {
+        app: './app',
+        context: 'app',
+        resolve: {
+          alias: {
+            '@assets': './app/assets',
+            '@components': './app/components',
+            '@containers': './app/containers',
+            '@config': './app/config',
+            '@navigators': './app/navigators',
+            '@services': './app/services',
+            '@themes': './app/themes',
+            '@utils': './app/utils'
           },
-          "paths": ["app"],
-          "modules": ["app", 'node_modules'],
-          "extensions": ['.js', '.jsx', '.json', '.coffee', '.cjsx'],
+          paths: ['app'],
+          modules: ['app', 'node_modules'],
+          extensions: ['.js', '.jsx', '.json', '.coffee', '.cjsx']
         }
       }
     }
   }
-}
+};

.gitignore

@@ -61,3 +61,5 @@ buck-out/
 .expo/
 web-build/
 dist/
+ios
+android

App.js

@@ -12,9 +12,7 @@ if (!window.Intl) {
   })
     .then(() => Promise.all([import('intl/locale-data/jsonp/en.js')]))
     .then(() => AppRegistry.registerComponent(appName, () => App))
-    .catch(err => {
-      throw err;
-    });
+    .catch(alert);
 } else {
   AppRegistry.registerComponent(appName, () => App);
 }

app.json

@@ -19,6 +19,9 @@
     },
     "android": {
       "package": "com.wednesdaysolutions.rntws"
+    },
+    "ios": {
+      "bundleIdentifier": "com.wednesdaysolutions.rntws"
     }
   }
 }

app/components/atoms/LanguageProvider/actions.js

@@ -1,14 +1,13 @@
-/*
- *
- * LanguageProvider actions
- *
- */
-
 import { CHANGE_LOCALE } from './constants';
 
+/**
+ * Description
+ * @param {any} languageLocale
+ * @returns {any}
+ */
 export function changeLocale(languageLocale) {
   return {
     type: CHANGE_LOCALE,
     locale: languageLocale
   };
 }

app/components/atoms/LanguageProvider/index.js

@@ -14,6 +14,11 @@ import { IntlProvider } from 'react-intl';
 
 import { makeSelectLocale } from './selectors';
 
+/**
+ * Description
+ * @param {any} props
+ * @returns {any}
+ */
 export function LanguageProvider(props) {
   return (
     <IntlProvider
@@ -36,6 +41,11 @@ const mapStateToProps = createSelector(makeSelectLocale(), locale => ({
   locale
 }));
 
+/**
+ * Description
+ * @param {any} dispatch
+ * @returns {any}
+ */
 function mapDispatchToProps(dispatch) {
   return {
     dispatch

app/components/atoms/LanguageProvider/reducer.js

@@ -22,12 +22,11 @@ export const initialState = fromJS({
 /* eslint-disable default-case, no-param-reassign */
 export const languageProviderReducer = (state = initialState, action) =>
   produce(state, (/* draft */) => {
-    switch (action.type) {
-      case languageProviderTypes.CHANGE_LOCALE:
-        return state.set('locale', action.locale);
-      default:
-        return state;
-    }
+    const actionType = {
+      [languageProviderTypes.CHANGE_LOCALE]: () =>
+        state.set('locale', action.locale)
+    };
+    return action.type in actionType ? actionType[action.type]() : state;
   });
 
 export default languageProviderReducer;

app/components/atoms/LanguageProvider/tests/index.test.js

@@ -1,16 +1,19 @@
 import React from 'react';
-import 'react-native';
 import { render } from '@testing-library/react-native';
 import { Provider } from 'react-redux';
 import T from '@atoms/T';
 import createStore from 'app/rootReducer';
 import { translationMessages } from 'app/i18n';
 import { renderWithIntl } from '@utils/testUtils';
 import ConnectedLanguageProvider, { LanguageProvider } from '../index';
-
+import { Text } from 'react-native';
 describe('<LanguageProvider /> container tests', () => {
   it('should render its children', () => {
-    const children = <h1>Test</h1>;
+    const children = (
+      <h1>
+        <Text>Test</Text>
+      </h1>
+    );
     const container = renderWithIntl(
       <LanguageProvider messages={translationMessages} locale="en">
         {children}
@@ -19,16 +22,10 @@ describe('<LanguageProvider /> container tests', () => {
     expect(container.firstChild).not.toBeNull();
   });
 });
-
+const setupReduxStore = () => ({ reduxStore: createStore().store });
 describe('<ConnectedLanguageProvider /> container tests', () => {
-  let reduxStore;
-
-  beforeAll(() => {
-    const { store } = createStore();
-    reduxStore = store;
-  });
-
   it('should render the default language messages', () => {
+    const { reduxStore } = setupReduxStore();
     const { queryByText } = render(
       <Provider store={reduxStore}>
         <ConnectedLanguageProvider messages={translationMessages}>

app/components/atoms/LanguageProvider/tests/reducer.test.js

@@ -3,26 +3,23 @@ import {
   languageProviderTypes,
   languageProviderReducer
 } from '../reducer';
-
+const setupMockedState = () => ({ mockedState: initialState });
 /* eslint-disable default-case, no-param-reassign */
 describe('Tests for LanguageProvider actions', () => {
-  let mockedState;
-  beforeEach(() => {
-    mockedState = initialState;
-  });
-
   it('returns the initial state', () => {
+    const { mockedState } = setupMockedState();
     expect(languageProviderReducer(undefined, {})).toEqual(mockedState);
   });
 
   it('changes the locale', () => {
+    const { mockedState } = setupMockedState();
     const locale = 'de';
-    mockedState = mockedState.set('locale', locale);
+    const UpdateMockedState = mockedState.set('locale', locale);
     expect(
       languageProviderReducer(undefined, {
         type: languageProviderTypes.CHANGE_LOCALE,
         locale
       })
-    ).toEqual(mockedState);
+    ).toEqual(UpdateMockedState);
   });
 });

app/components/molecules/CharacterWithQuote/index.js

@@ -17,6 +17,11 @@ const CharacterImage = styled.Image`
   margin: 0 auto;
 `;
 
+/**
+ * Description
+ * @param {any} {user}
+ * @returns {any}
+ */
 function CharacterWithQuote({ user }) {
   return (
     <>

app/components/molecules/If/index.js

@@ -4,21 +4,24 @@
  *
  */
 // eslint-disable-next-line
-import React from 'react'
-import Proptypes from 'prop-types';
+import PropTypes from 'prop-types';
+
 const If = props => (props.condition ? props.children : props.otherwise);
-If.propsTypes = {
-  condition: Proptypes.bool,
-  otherwise: Proptypes.oneOfType([
-    Proptypes.arrayOf(Proptypes.node),
-    Proptypes.node
+
+If.propTypes = {
+  condition: PropTypes.bool,
+  otherwise: PropTypes.oneOfType([
+    PropTypes.arrayOf(PropTypes.node),
+    PropTypes.node
   ]),
-  children: Proptypes.oneOfType([
-    Proptypes.arrayOf(Proptypes.node),
-    Proptypes.node
+  children: PropTypes.oneOfType([
+    PropTypes.arrayOf(PropTypes.node),
+    PropTypes.node
   ])
 };
+
 If.defaultProps = {
   otherwise: null
 };
+
 export default If;

app/components/molecules/If/tests/index.test.js

@@ -32,9 +32,9 @@ describe('<If />', () => {
       </If>
     );
     expect(getByText(conditionTrueText)).toBeTruthy();
-    props.condition = false;
+    const falseProps = { ...props, condition: false };
     const { getByText: textQueryOnReRender } = render(
-      <If {...props}>
+      <If {...falseProps}>
         <TrueConditionComponent />
       </If>
     );